Allow the maximum number of thinking tokens to be allowed for Claude #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default chatgpt-shell-anthropic-thinking-budget-tokens is 32000. This exceeds the maximum number of tokens for some models (e.g. Opus 4) and is a pain since the maximum number of tokens differs across different anthropic models. This PR allows a value of 'max which uses as many thinking tokens as possible.
xenodium
reviewed
Jun 18, 2025
chatgpt-shell-anthropic.el
Outdated
| "The token budget allocated for Anthropic model thinking. | ||
|
|
||
| Needs `chatgpt-shell-anthropic-thinking-budget-tokens' set to non-nil." | ||
| :type 'integer | ||
| :type '(choice integer (const max)) |
There was a problem hiding this comment.
Can we use nil to mean no limit (ie. max)?
There was a problem hiding this comment.
Sure, that seems fine too. I'll change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default chatgpt-shell-anthropic-thinking-budget-tokens is 32000. This exceeds
the maximum number of tokens for some models (e.g. Opus 4) and is a pain since
the maximum number of tokens differs across different anthropic models. This PR
allows a value of 'max which uses as many thinking tokens as possible.