Avoid throwing exceptions by creating a php://memory fallback stream

Author: xmarcos

src/CarbonClientServiceProvider.php

@@ -1,6 +1,7 @@
 <?php
 namespace xmarcos\Silex;
 
+use ErrorException;
 use Silex\Application;
 use xmarcos\Carbon\Client;
 use InvalidArgumentException;
@@ -55,21 +56,27 @@ private function createClient(array $params = [])
             array_intersect_key($params, $defaults)
         );
 
-        if (!empty($args['stream'])) {
-            $stream = $args['stream'];
-        } else {
+        $stream    = $args['stream'];
+        $exception = null;
+
+        if (!is_resource($stream)) {
+            set_error_handler(function ($code, $message, $file = null, $line = 0) use (&$exception) {
+                $exception = new ErrorException($message, $code, null, $file, $line);
+            });
             $address = sprintf('%s://%s:%d', $args['transport'], $args['host'], $args['port']);
-            $stream  = @stream_socket_client($address);
+            $stream  = stream_socket_client($address);
+            restore_error_handler();
         }
 
         try {
             $carbon = new Client($stream);
             $carbon->setNamespace($args['namespace']);
-
-            return $carbon;
         } catch (InvalidArgumentException $e) {
-            throw $e;
+            $carbon = new Client(fopen('php://memory', 'r'));
+            $carbon->setNamespace($args['namespace']);
         }
+
+        return $carbon;
     }
 
     /**

tests/CarbonClientServiceProviderTest.php

@@ -84,15 +84,31 @@ public function testRegisterWithNamespace()
     }
 
     /**
-     * @expectedException InvalidArgumentException
+     * @dataProvider providerWrongParams
      */
-    public function testRegisterWithInvaidParamsThrowsException()
+    public function testRegisterWithInvalidStreamCreatesFallbackMemoryStream($params)
     {
         $this->app->register(new CarbonClientServiceProvider(), [
-            'carbon.params' => [
-                'transport' => 'invalid_transport',
-            ]
+            'carbon.params' => $params
         ]);
-        $trigger_exception = $this->app['carbon'];
+        $carbon_stream = (new ReflectionClass($this->app['carbon']))->getProperty('stream');
+        $carbon_stream->setAccessible(true);
+
+        $type = stream_get_meta_data($carbon_stream->getValue($this->app['carbon']))['stream_type'];
+        $this->assertEquals('MEMORY', $type);
+    }
+
+    public function providerWrongParams()
+    {
+        return [
+            [['transport' => 'invalid_transport']],
+            [
+                [
+                    'transport' => 'tcp',
+                    'host'      => 'localhost',
+                    'port'      => 25,
+                ]
+            ],
+        ];
     }
 }