Skip to content
This repository was archived by the owner on Apr 19, 2023. It is now read-only.

Demote to unusable pre-preview status #14

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Conversation

elisealix22
Copy link
Contributor

@elisealix22 elisealix22 commented Jan 13, 2023

We found a blocking issue in: #13. In the meantime, we recommend loading the XMTP client SDK for JavaScript directly into a WebView as a workaround.

We found a blocking issue in: #13. In the meantime, we recommend developers use WebViews to integrate with `xmtp-js`.
Copy link
Contributor

@jhaaaa jhaaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the tag for review, @elisealix22 - so grateful for the heads up! <3

My only feedback is about whether we want to use the "Pre-Preview" language from the release lifecycle @yash-luna or adjust the language to "Early Developer Preview"? In terms of how it reads in the README doc, I think "Early Developer Preview" works well! But just wanted to be sure.

Here are badges we can use in either case:

Once we merge this update, I'll update the status of the app as listed on https://xmtp.org/sdks-and-tools.

Copy link
Contributor

@yash-luna yash-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on explicitly changing status & badge to Pre-Preview to make it clear that RN is not same level of readiness as Flutter & iOS?

@elisealix22
Copy link
Contributor Author

@yash-luna @jhaaaa happy to rename to pre-preview! One note is that I was borrowing the language/color from https://github.com/xmtp/xmtp-memo-js. Should I update the language there as well?

Elise Alix added 2 commits January 13, 2023 08:32
Updates the badge and README to use Pre-Preview instead of Developer Preview.
@jhaaaa
Copy link
Contributor

jhaaaa commented Jan 13, 2023

Ah, got it, @elisealix22 - so thorough and thoughtful at all times - thank you for helping to keep things consistent! I will go ahead and create a PR to update xmtp-memo-js to use the Pre-Preview status language!

@elisealix22 elisealix22 merged commit f17abb2 into main Jan 13, 2023
@elisealix22 elisealix22 deleted the ea/demote-pre-preview branch January 13, 2023 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants