This repository was archived by the owner on Apr 19, 2023. It is now read-only.
Add WalletConnect auth #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neekolas
reviewed
Nov 21, 2022
elisealix22
commented
Dec 1, 2022
|
Alright, @neekolas @bhavya2611 this should be ready for review for real now! Tested on physical devices for each platform. |
neekolas
approved these changes
Dec 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds WalletConnect v1 integration to authenticate with XMTP. We will have to upgrade to v2 by March 1, 2023 which we are tracking here. For now though, I haven't found much guidance for dapps on how to upgrade as it seems they are focusing on wallets upgrading first.
WC upgrade schedule
Also, I had to patch the v1 WC module because it was not working on Android. I'm hoping when we switch to v2, we'll be able to clean this all up.
Testing steps
Demos