Add disappearing message methods to Conversation (WASM) (#1650)

* Update README

* Add check:macos script

* Remove auto filtering of messages in DM groups

* Update JS names of MessageDisappearingSettings fields

* Add message filtering methods to groups

* Update version and changelog

Author: rygine

bindings_wasm/CHANGELOG.md

@@ -1,5 +1,14 @@
 # @xmtp/wasm-bindings
 
+## 0.0.16
+
+- Added `isMessageDisappearingEnabled` method to `Conversation`
+- Added `messageDisappearingSettings` method to `Conversation`
+- Added `removeMessageDisappearingSettings` method to `Conversation`
+- Added `messageDisappearingSettings` method to `Conversation`
+- Updated JS names for `MessageDisappearingSettings` fields
+- Removed automatic filtering of DM group messages
+
 ## 0.0.15
 
 - Added `consent_states`, `include_sync_groups`, and `include_duplicate_dms` to `ListConversationsOptions`

bindings_wasm/README.md

@@ -8,3 +8,8 @@
 - `yarn`: Installs all dependencies (required before building)
 - `yarn build`: Build a release version of the WASM bindings for the current platform
 - `yarn lint`: Run cargo clippy and fmt checks
+- `yarn check:macos`: Run cargo check for macOS (requires Homebrew and `llvm` to be installed)
+
+# Publishing
+
+To release a new version of the bindings, update the version in `package.json` with the appropriate semver value and add an entry to the CHANGELOG.md file. Once merged, manually trigger the `Release WASM Bindings` workflow to build and publish the bindings.

bindings_wasm/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xmtp/wasm-bindings",
-  "version": "0.0.15",
+  "version": "0.0.16",
   "type": "module",
   "license": "MIT",
   "description": "WASM bindings for the libXMTP rust library",
@@ -27,6 +27,7 @@
     "build": "yarn clean && yarn build:web && yarn build:copy && yarn clean:release",
     "build:web": "cargo xtask build BindingsWasm --out-dir ./dist --plain -- --release",
     "build:copy": "node scripts/copyFiles.js",
+    "check:macos": "CC_wasm32_unknown_unknown=/opt/homebrew/opt/llvm/bin/clang cargo check --target wasm32-unknown-unknown",
     "clean:release": "rm -f ./dist/package.json",
     "clean": "rm -rf ./dist",
     "lint": "yarn lint:clippy && yarn lint:fmt",

bindings_wasm/src/conversation.rs

@@ -4,6 +4,7 @@ use wasm_bindgen::{prelude::wasm_bindgen, JsError};
 use xmtp_mls::storage::group::ConversationType;
 
 use crate::client::RustXmtpClient;
+use crate::conversations::MessageDisappearingSettings;
 use crate::encoded_content::EncodedContent;
 use crate::messages::{ListMessagesOptions, Message};
 use crate::permissions::{MetadataField, PermissionPolicy, PermissionUpdateType};
@@ -15,7 +16,7 @@ use xmtp_mls::groups::{
   intents::PermissionUpdateType as XmtpPermissionUpdateType,
   members::PermissionLevel as XmtpPermissionLevel, MlsGroup, UpdateAdminListType,
 };
-use xmtp_mls::storage::group_message::{GroupMessageKind as XmtpGroupMessageKind, MsgQueryArgs};
+use xmtp_mls::storage::group_message::MsgQueryArgs;
 use xmtp_proto::xmtp::mls::message_contents::EncodedContent as XmtpEncodedContent;
 
 use prost::Message as ProstMessage;
@@ -199,7 +200,7 @@ impl Conversation {
       .map_err(|e| JsError::new(&format!("{e}")))?;
     let kind = match conversation_type {
       ConversationType::Group => None,
-      ConversationType::Dm => Some(XmtpGroupMessageKind::Application),
+      ConversationType::Dm => None,
       ConversationType::Sync => None,
     };
 
@@ -558,6 +559,55 @@ impl Conversation {
       .await
       .map_err(Into::into)
   }
+
+  #[wasm_bindgen(js_name = updateMessageDisappearingSettings)]
+  pub async fn update_message_disappearing_settings(
+    &self,
+    settings: MessageDisappearingSettings,
+  ) -> Result<(), JsError> {
+    self
+      .to_mls_group()
+      .update_conversation_message_disappearing_settings(settings.into())
+      .await
+      .map_err(|e| JsError::new(&format!("{e}")))?;
+
+    Ok(())
+  }
+
+  #[wasm_bindgen(js_name = removeMessageDisappearingSettings)]
+  pub async fn remove_message_disappearing_settings(&self) -> Result<(), JsError> {
+    self
+      .to_mls_group()
+      .remove_conversation_message_disappearing_settings()
+      .await
+      .map_err(|e| JsError::new(&format!("{e}")))?;
+
+    Ok(())
+  }
+
+  #[wasm_bindgen(js_name = messageDisappearingSettings)]
+  pub fn message_disappearing_settings(
+    &self,
+  ) -> Result<Option<MessageDisappearingSettings>, JsError> {
+    let settings = self
+      .inner_client
+      .group_disappearing_settings(self.group_id.clone())
+      .map_err(|e| JsError::new(&format!("{e}")))?;
+
+    match settings {
+      Some(s) => Ok(Some(s.into())),
+      None => Ok(None),
+    }
+  }
+
+  #[wasm_bindgen(js_name = isMessageDisappearingEnabled)]
+  pub fn is_message_disappearing_enabled(&self) -> Result<bool, JsError> {
+    self.message_disappearing_settings().map(|settings| {
+      settings
+        .as_ref()
+        .is_some_and(|s| s.from_ns > 0 && s.in_ns > 0)
+    })
+  }
 }
 
 #[cfg(test)]

bindings_wasm/src/conversations.rs

@@ -143,7 +143,9 @@ impl ListConversationsOptions {
 #[wasm_bindgen(getter_with_clone)]
 #[derive(Clone)]
 pub struct MessageDisappearingSettings {
+  #[wasm_bindgen(js_name = fromNs)]
   pub from_ns: i64,
+  #[wasm_bindgen(js_name = inNs)]
   pub in_ns: i64,
 }
 
@@ -156,6 +158,15 @@ impl From<MessageDisappearingSettings> for XmtpMessageDisappearingSettings {
   }
 }
 
+impl From<XmtpMessageDisappearingSettings> for MessageDisappearingSettings {
+  fn from(value: XmtpMessageDisappearingSettings) -> Self {
+    Self {
+      from_ns: value.from_ns,
+      in_ns: value.in_ns,
+    }
+  }
+}
+
 #[wasm_bindgen]
 impl MessageDisappearingSettings {
   #[wasm_bindgen(constructor)]