Skip to content

Commit c74d240

Browse files
authored
Update missing signatures function for validation service (#1733)
* update missing signatures * comment
1 parent 75f5363 commit c74d240

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

bindings_ffi/src/mls.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -3324,7 +3324,8 @@ mod tests {
33243324
// should be good
33253325
.unwrap();
33263326

3327-
// TODO: uncomment this when xmtp-node-go is updated to recognize Passkey MemberIdentifiers
3327+
// TODO: I'll uncomment this as soon as PR 1733 goes live.
3328+
// Tested locally with this uncommented and it works.
33283329
// alex.apply_signature_request(sig_request).await.unwrap();
33293330
}
33303331

xmtp_id/src/associations/builder.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ impl SignatureRequest {
207207
pub fn missing_address_signatures(&self) -> Vec<&MemberIdentifier> {
208208
self.missing_signatures()
209209
.into_iter()
210-
.filter(|member| member.kind() == MemberKind::Ethereum)
210+
.filter(|member| matches!(member.kind(), MemberKind::Ethereum | MemberKind::Passkey))
211211
.collect()
212212
}
213213

0 commit comments

Comments
 (0)