-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Identity #1621
Merged
Merged
Migrate Identity #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proto: xmtp/proto#245
Migrate Identity
In our old identity system in libxmtp,
String
was assumed to be an ethereum address andVec<u8>
was assumed to be an installation key. This posed a few issues - for example sanitizing addresses was difficult since there was no "entry point" for addresses as they were just strings, it limited extensibility to other chains, and prevented us from implementing behaviors nicely on certain identities.To fix this, each identity type is now wrapped in a struct. Before, a simple
String
that represented an ethereum address is nowEthereum(String)
, but you'll rarely find yourself dealing with theEthereum
struct directly. Instead - there is one new enum along-side the previously existing enumMemberIdentifier
:PublicIdentifier
MemberIdentifier
(libXmtp only)Identifier
(libXmtp and FFI)This PR does not include P256 signature validation and only focuses on the identity migration. That is coming in a fast follow.