Use opfs-sahpool from diesel, remove sqlite-web #1676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insipx
force-pushed
the
insipx/no-coop-headers
branch
4 times, most recently
from
dbdb7b4 to
1baf234
Compare
* clean up a bunch of v2 stuff * clean up of v2 libraries * fix up lint * cargo fmt * reorder file
* add hmac keys for conversation * Add conversation hmac keys test * Use Uint8Array for HmacKey key * Minor cleanup * Return Vec instead of HashMap * write an ffi test --------- Co-authored-by: Ry Racherbaumer <ry@xmtp.com>
…er-sdk with the latest wasm compiled in libxmtp
|
screwed up a merge re-opened in #1690 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmed working by running browser-sdk tests with these lines removed
Also comes with a pretty huge performance improvement for web, since the wasm -> js barrier within libxmtp is removed
@rygine this will now require the emscripten SDK to build the wasm bindings, should just be
brew install emscripten. The buildscript in sqlite dependency compiles it from source. I'd prefer it this way just for security reasons, and also the ability to eventually link to our own version of sqlite/libc -- might be able to make the binary size smallerwasm-pack)dev/test/browser-sdkscript, which clones xmtp-js/browser sdk and tests it with the latest wasm bindings using nixfixes #1659
this means we no longer need to maintain https://github.com/xmtp/sqlite-web-rs