Updating shouldPush flag and removing issues in instrumental testing

Author: giovas17

library/src/androidTest/java/org/xmtp/android/library/ClientTest.kt

@@ -63,7 +63,7 @@ class ClientTest {
         )
     }
 
-    @Ignore
+    @Ignore("CI Issues")
     @Test
     fun testCanBeCreatedWithV1Bundle() {
         val fakeWallet = PrivateKeyBuilder()
@@ -81,7 +81,7 @@ class ClientTest {
         )
     }
 
-    @Ignore
+    @Ignore("CI Issues")
     @Test
     fun testV3CanBeCreatedWithBundle() {
         val context = InstrumentationRegistry.getInstrumentation().targetContext
@@ -111,7 +111,7 @@ class ClientTest {
         )
     }
 
-    @Ignore
+    @Ignore("CI Issues")
     @Test
     fun testCreatesAV3Client() {
         val context = InstrumentationRegistry.getInstrumentation().targetContext

library/src/androidTest/java/org/xmtp/android/library/CodecTest.kt

@@ -148,7 +148,7 @@ class CodecTest {
         val keys = aliceClient.conversations.getHmacKeys()
     }
 
-    @Ignore
+    @Ignore("CI Issues")
     @Test
     fun testReturnsAllHMACKeys() {
         val alix = PrivateKeyBuilder()

library/src/androidTest/java/org/xmtp/android/library/GroupMembershipChangeTest.kt

@@ -14,7 +14,7 @@ import org.xmtp.android.library.messages.walletAddress
 import uniffi.xmtpv3.org.xmtp.android.library.codecs.GroupMembershipChangeCodec
 import uniffi.xmtpv3.org.xmtp.android.library.codecs.GroupMembershipChanges
 
-@Ignore
+@Ignore("CI Issues")
 @RunWith(AndroidJUnit4::class)
 class GroupMembershipChangeTest {
     lateinit var fakeApiClient: FakeApiClient

library/src/androidTest/java/org/xmtp/android/library/GroupTest.kt

@@ -19,7 +19,7 @@ import org.xmtp.android.library.messages.PrivateKey
 import org.xmtp.android.library.messages.PrivateKeyBuilder
 import org.xmtp.android.library.messages.walletAddress
 
-@Ignore
+@Ignore("CI Issues")
 @RunWith(AndroidJUnit4::class)
 class GroupTest {
     lateinit var fakeApiClient: FakeApiClient

library/src/main/java/org/xmtp/android/library/ConversationV1.kt

@@ -127,7 +127,6 @@ data class ConversationV1(
                 encodedContent = encodedMessage,
                 senderAddress = header.sender.walletAddress,
                 sentAt = message.v1.sentAt,
-                shouldPush = false,
             )
         } catch (e: Exception) {
             throw XMTPException("Error decrypting message", e)

library/src/main/java/org/xmtp/android/library/ConversationV2.kt

@@ -250,7 +250,7 @@ data class ConversationV2(
             topic = topic,
             keyMaterial = keyMaterial,
             codec = codec,
-            shouldPush = options?.shouldPush
+            shouldPush = options?.__shouldPush
         )
 
         val newTopic = if (options?.ephemeral == true) ephemeralTopic else topic

library/src/main/java/org/xmtp/android/library/Group.kt

@@ -125,7 +125,6 @@ class Group(val client: Client, private val libXMTPGroup: FfiGroup) {
             encodedContent = message.decode().encodedContent,
             senderAddress = message.senderAddress,
             sentAt = Date(),
-            shouldPush = false,
         )
     }
 

library/src/main/java/org/xmtp/android/library/SendOptions.kt

@@ -6,5 +6,5 @@ data class SendOptions(
     var compression: EncodedContentCompression? = null,
     var contentType: Content.ContentTypeId? = null,
     var ephemeral: Boolean = false,
-    var shouldPush: Boolean? = null
+    var __shouldPush: Boolean? = null
 )

library/src/main/java/org/xmtp/android/library/messages/DecryptedMessage.kt

@@ -9,5 +9,5 @@ data class DecryptedMessage(
     var senderAddress: String,
     var sentAt: Date,
     var topic: String = "",
-    var shouldPush: Boolean?
+    var shouldPush: Boolean? = null,
 )

library/src/main/java/org/xmtp/android/library/messages/MessageV2.kt

@@ -121,7 +121,7 @@ class MessageV2Builder(val senderHmac: ByteArray? = null, val shouldPush: Boolea
                 senderAddress = signed.sender.walletAddress,
                 sentAt = Date(header.createdNs / 1_000_000),
                 topic = topic,
-                shouldPush = false,
+                shouldPush = message.shouldPush,
             )
         }