Skip to content

Commit 2f4abdc

Browse files
committed
update the syncing in the tests
1 parent eae74a3 commit 2f4abdc

File tree

4 files changed

+23
-1
lines changed

4 files changed

+23
-1
lines changed

example/src/main/java/org/xmtp/android/example/conversation/ConversationDetailViewModel.kt

+4
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import org.xmtp.android.example.extension.flowWhileShared
2020
import org.xmtp.android.example.extension.stateFlow
2121
import org.xmtp.android.library.Conversation
2222
import org.xmtp.android.library.DecodedMessage
23+
import org.xmtp.android.library.Group
2324

2425
class ConversationDetailViewModel(private val savedStateHandle: SavedStateHandle) : ViewModel() {
2526

@@ -55,6 +56,9 @@ class ConversationDetailViewModel(private val savedStateHandle: SavedStateHandle
5556
)
5657
}
5758
conversation?.let {
59+
if (conversation is Conversation.Group) {
60+
(conversation as Conversation.Group).group.sync()
61+
}
5862
listItems.addAll(
5963
it.messages().map { message ->
6064
MessageListItem.Message(message.id, message)

library/src/androidTest/java/org/xmtp/android/library/GroupMembershipChangeTest.kt

+13
Original file line numberDiff line numberDiff line change
@@ -93,4 +93,17 @@ class GroupMembershipChangeTest {
9393
)
9494
assert(content?.membersAddedList.isNullOrEmpty())
9595
}
96+
97+
@Test
98+
fun testIfNotRegisteredReturnsFallback() {
99+
val group = alixClient.conversations.newGroup(
100+
listOf(
101+
bo.walletAddress.lowercase(),
102+
caro.walletAddress.lowercase()
103+
)
104+
)
105+
val messages = group.messages()
106+
assertEquals(messages.size, 1)
107+
assert(messages.first().fallbackContent.isBlank())
108+
}
96109
}

library/src/androidTest/java/org/xmtp/android/library/GroupTest.kt

+6
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import androidx.test.ext.junit.runners.AndroidJUnit4
44
import androidx.test.platform.app.InstrumentationRegistry
55
import app.cash.turbine.test
66
import kotlinx.coroutines.ExperimentalCoroutinesApi
7+
import kotlinx.coroutines.runBlocking
78
import org.junit.Assert.assertEquals
89
import org.junit.Before
910
import org.junit.Test
@@ -138,10 +139,13 @@ class GroupTest {
138139
val group = boClient.conversations.newGroup(listOf(alix.walletAddress.lowercase()))
139140
group.send("howdy")
140141
group.send("gm")
142+
runBlocking { group.sync() }
141143
assertEquals(group.messages().first().body, "gm")
142144
assertEquals(group.messages().size, 3)
143145

146+
runBlocking { alixClient.conversations.syncGroups() }
144147
val sameGroup = alixClient.conversations.listGroups().last()
148+
runBlocking { sameGroup.sync() }
145149
assertEquals(sameGroup.messages().size, 2)
146150
assertEquals(sameGroup.messages().first().body, "gm")
147151
}
@@ -152,6 +156,7 @@ class GroupTest {
152156

153157
val group = boClient.conversations.newGroup(listOf(alix.walletAddress.lowercase()))
154158
group.send("gm")
159+
runBlocking { group.sync() }
155160
val messageToReact = group.messages()[0]
156161

157162
val reaction = Reaction(
@@ -162,6 +167,7 @@ class GroupTest {
162167
)
163168

164169
group.send(content = reaction, options = SendOptions(contentType = ContentTypeReaction))
170+
runBlocking { group.sync() }
165171

166172
val messages = group.messages()
167173
assertEquals(messages.size, 3)

library/src/main/java/org/xmtp/android/library/Client.kt

-1
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,6 @@ class Client() {
257257
val apiClient =
258258
GRPCApiClient(environment = newOptions.api.env, secure = newOptions.api.isSecure)
259259
val v3Client: FfiXmtpClient? = if (isAlphaMlsEnabled(options)) {
260-
if (account == null) throw XMTPException("Signing Key required to use groups.")
261260
runBlocking {
262261
ffiXmtpClient(
263262
options,

0 commit comments

Comments
 (0)