Skip to content

Commit 986ca27

Browse files
authored
Remove timestamp from read receipts (#118)
* change the read reciept to no longer include a timestamp paramater * fix linter issues
1 parent 84a6620 commit 986ca27

File tree

2 files changed

+5
-12
lines changed

2 files changed

+5
-12
lines changed

library/src/androidTest/java/org/xmtp/android/library/ReadReceiptTest.kt

+3-3
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class ReadReceiptTest {
2323

2424
aliceConversation.send(text = "hey alice 2 bob")
2525

26-
val readReceipt = ReadReceipt(timestamp = "2019-09-26T07:58:30.996+0200")
26+
val readReceipt = ReadReceipt
2727

2828
aliceConversation.send(
2929
content = readReceipt,
@@ -32,8 +32,8 @@ class ReadReceiptTest {
3232
val messages = aliceConversation.messages()
3333
assertEquals(messages.size, 2)
3434
if (messages.size == 2) {
35-
val content: ReadReceipt? = messages.first().content()
36-
assertEquals("2019-09-26T07:58:30.996+0200", content?.timestamp)
35+
val contentType: String = messages.first().encodedContent.type.typeId
36+
assertEquals(contentType, "readReceipt")
3737
}
3838
}
3939
}

library/src/main/java/org/xmtp/android/library/codecs/ReadReceiptCodec.kt

+2-9
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package org.xmtp.android.library.codecs
22

33
import com.google.protobuf.ByteString
4-
import org.xmtp.android.library.XMTPException
54

65
val ContentTypeReadReceipt = ContentTypeIdBuilder.builderFromAuthorityId(
76
"xmtp.org",
@@ -10,26 +9,20 @@ val ContentTypeReadReceipt = ContentTypeIdBuilder.builderFromAuthorityId(
109
versionMinor = 0
1110
)
1211

13-
data class ReadReceipt(
14-
// The timestamp the read receipt was sent, in ISO 8601 format
15-
val timestamp: String,
16-
)
12+
object ReadReceipt
1713

1814
data class ReadReceiptCodec(override var contentType: ContentTypeId = ContentTypeReadReceipt) :
1915
ContentCodec<ReadReceipt> {
2016

2117
override fun encode(content: ReadReceipt): EncodedContent {
2218
return EncodedContent.newBuilder().also {
2319
it.type = ContentTypeReadReceipt
24-
it.putParameters("timestamp", content.timestamp)
2520
it.content = ByteString.EMPTY
2621
}.build()
2722
}
2823

2924
override fun decode(content: EncodedContent): ReadReceipt {
30-
val timestamp = content.parametersMap["timestamp"] ?: throw XMTPException("Invalid Content")
31-
32-
return ReadReceipt(timestamp = timestamp)
25+
return ReadReceipt
3326
}
3427

3528
override fun fallback(content: ReadReceipt): String? {

0 commit comments

Comments
 (0)