improve the publish and write a test

Author: nplasterer

library/src/androidTest/java/org/xmtp/android/library/ConversationTest.kt

@@ -848,6 +848,23 @@ class ConversationTest {
         assertTrue(isNowAllowed)
     }
 
+    @Test
+    fun testCanPublishMultipleAddressConsentState() {
+        runBlocking {
+            val bobConversation = bobClient.conversations.newConversation(alice.walletAddress)
+            val caroConversation =
+                bobClient.conversations.newConversation(fixtures.caro.walletAddress)
+
+            assertEquals(bobClient.contacts.consentList.entries.size, 2)
+            assertTrue(bobConversation.consentState() == ConsentState.ALLOWED)
+            assertTrue(caroConversation.consentState() == ConsentState.ALLOWED)
+            bobClient.contacts.deny(listOf(alice.walletAddress, fixtures.caro.walletAddress))
+            assertEquals(bobClient.contacts.consentList.entries.size, 2)
+            assertTrue(bobConversation.consentState() == ConsentState.DENIED)
+            assertTrue(caroConversation.consentState() == ConsentState.DENIED)
+        }
+    }
+
     @Test
     fun testCanValidateTopicsInsideConversation() {
         val validId = "sdfsadf095b97a9284dcd82b2274856ccac8a21de57bebe34e7f9eeb855fb21126d3b8f"

library/src/main/java/org/xmtp/android/library/Contacts.kt

@@ -109,63 +109,62 @@ class ConsentList(
     }
 
     suspend fun publish(entries: List<ConsentListEntry>) {
-        val envelopes = entries.map { entry ->
-            val payload =
-                PrivatePreferencesAction.newBuilder().also {
-                    when (entry.entryType) {
-                        ConsentListEntry.EntryType.ADDRESS -> {
-                            when (entry.consentType) {
-                                ConsentState.ALLOWED ->
-                                    it.setAllowAddress(
-                                        PrivatePreferencesAction.AllowAddress.newBuilder()
-                                            .addWalletAddresses(entry.value),
-                                    )
-
-                                ConsentState.DENIED ->
-                                    it.setDenyAddress(
-                                        PrivatePreferencesAction.DenyAddress.newBuilder()
-                                            .addWalletAddresses(entry.value),
-                                    )
-
-                                ConsentState.UNKNOWN -> it.clearMessageType()
-                            }
+        val payload = PrivatePreferencesAction.newBuilder().also {
+            entries.forEach { entry ->
+                when (entry.entryType) {
+                    ConsentListEntry.EntryType.ADDRESS -> {
+                        when (entry.consentType) {
+                            ConsentState.ALLOWED ->
+                                it.setAllowAddress(
+                                    PrivatePreferencesAction.AllowAddress.newBuilder()
+                                        .addWalletAddresses(entry.value),
+                                )
+
+                            ConsentState.DENIED ->
+                                it.setDenyAddress(
+                                    PrivatePreferencesAction.DenyAddress.newBuilder()
+                                        .addWalletAddresses(entry.value),
+                                )
+
+                            ConsentState.UNKNOWN -> it.clearMessageType()
                         }
+                    }
 
-                        ConsentListEntry.EntryType.GROUP_ID -> {
-                            when (entry.consentType) {
-                                ConsentState.ALLOWED ->
-                                    it.setAllowGroup(
-                                        PrivatePreferencesAction.AllowGroup.newBuilder()
-                                            .addGroupIds(entry.value.toByteStringUtf8()),
-                                    )
-
-                                ConsentState.DENIED ->
-                                    it.setDenyGroup(
-                                        PrivatePreferencesAction.DenyGroup.newBuilder()
-                                            .addGroupIds(entry.value.toByteStringUtf8()),
-                                    )
-
-                                ConsentState.UNKNOWN -> it.clearMessageType()
-                            }
+                    ConsentListEntry.EntryType.GROUP_ID -> {
+                        when (entry.consentType) {
+                            ConsentState.ALLOWED ->
+                                it.setAllowGroup(
+                                    PrivatePreferencesAction.AllowGroup.newBuilder()
+                                        .addGroupIds(entry.value.toByteStringUtf8()),
+                                )
+
+                            ConsentState.DENIED ->
+                                it.setDenyGroup(
+                                    PrivatePreferencesAction.DenyGroup.newBuilder()
+                                        .addGroupIds(entry.value.toByteStringUtf8()),
+                                )
+
+                            ConsentState.UNKNOWN -> it.clearMessageType()
                         }
                     }
-                }.build()
-
-            val message =
-                uniffi.xmtpv3.userPreferencesEncrypt(
-                    publicKey.toByteArray(),
-                    privateKey.toByteArray(),
-                    payload.toByteArray(),
-                )
+                }
+            }
+        }.build()
 
-            EnvelopeBuilder.buildFromTopic(
-                Topic.preferenceList(identifier),
-                Date(),
-                ByteArray(message.size) { message[it] },
+        val message =
+            uniffi.xmtpv3.userPreferencesEncrypt(
+                publicKey.toByteArray(),
+                privateKey.toByteArray(),
+                payload.toByteArray(),
             )
-        }
 
-        client.publish(envelopes)
+        val envelope = EnvelopeBuilder.buildFromTopic(
+            Topic.preferenceList(identifier),
+            Date(),
+            ByteArray(message.size) { message[it] },
+        )
+
+        client.publish(listOf(envelope))
     }
 
     fun allow(address: String): ConsentListEntry {