add more involved tests around permissions

Author: nplasterer

library/src/androidTest/java/org/xmtp/android/library/GroupTest.kt

@@ -58,18 +58,63 @@ class GroupTest {
     }
 
     @Test
-    fun testCanCreateAGroup() {
-        val group = boClient.conversations.newGroup(listOf(alix.walletAddress))
-        assert(group.id.isNotEmpty())
+    fun testCanCreateAGroupWithDefaultPermissions() {
+        val boGroup = boClient.conversations.newGroup(listOf(alix.walletAddress))
+        runBlocking { alixClient.conversations.syncGroups() }
+        val alixGroup = alixClient.conversations.listGroups().first()
+        assert(boGroup.id.isNotEmpty())
+        assert(alixGroup.id.isNotEmpty())
+
+        alixGroup.addMembers(listOf(caro.walletAddress))
+        runBlocking { boGroup.sync() }
+        assertEquals(alixGroup.memberAddresses().size, 3)
+        assertEquals(boGroup.memberAddresses().size, 3)
+
+        alixGroup.removeMembers(listOf(caro.walletAddress))
+        runBlocking { boGroup.sync() }
+        assertEquals(alixGroup.memberAddresses().size, 2)
+        assertEquals(boGroup.memberAddresses().size, 2)
+
+        boGroup.addMembers(listOf(caro.walletAddress))
+        runBlocking { alixGroup.sync() }
+        assertEquals(alixGroup.memberAddresses().size, 3)
+        assertEquals(boGroup.memberAddresses().size, 3)
     }
 
     @Test
     fun testCanCreateAGroupWithAdminPermissions() {
-        val group = boClient.conversations.newGroup(
+        val boGroup = boClient.conversations.newGroup(
             listOf(alix.walletAddress),
             permissions = GroupPermissions.GROUP_CREATOR_IS_ADMIN
         )
-        assert(group.id.isNotEmpty())
+        runBlocking { alixClient.conversations.syncGroups() }
+        val alixGroup = alixClient.conversations.listGroups().first()
+        assert(boGroup.id.isNotEmpty())
+        assert(alixGroup.id.isNotEmpty())
+
+        boGroup.addMembers(listOf(caro.walletAddress))
+        runBlocking { alixGroup.sync() }
+        assertEquals(alixGroup.memberAddresses().size, 3)
+        assertEquals(boGroup.memberAddresses().size, 3)
+
+        assertThrows(XMTPException::class.java) {
+            alixGroup.removeMembers(listOf(caro.walletAddress))
+        }
+        runBlocking { boGroup.sync() }
+        assertEquals(alixGroup.memberAddresses().size, 3)
+        assertEquals(boGroup.memberAddresses().size, 3)
+
+        boGroup.removeMembers(listOf(caro.walletAddress))
+        runBlocking { alixGroup.sync() }
+        assertEquals(alixGroup.memberAddresses().size, 2)
+        assertEquals(boGroup.memberAddresses().size, 2)
+
+        assertThrows(XMTPException::class.java) {
+            alixGroup.addMembers(listOf(caro.walletAddress))
+        }
+        runBlocking { boGroup.sync() }
+        assertEquals(alixGroup.memberAddresses().size, 2)
+        assertEquals(boGroup.memberAddresses().size, 2)
     }
 
     @Test

library/src/main/java/org/xmtp/android/library/Group.kt

@@ -15,6 +15,7 @@ import uniffi.xmtpv3.FfiGroup
 import uniffi.xmtpv3.FfiListMessagesOptions
 import uniffi.xmtpv3.FfiMessage
 import uniffi.xmtpv3.FfiMessageCallback
+import java.lang.Exception
 import java.util.Date
 import kotlin.time.Duration.Companion.nanoseconds
 import kotlin.time.DurationUnit
@@ -133,11 +134,19 @@ class Group(val client: Client, private val libXMTPGroup: FfiGroup) {
     }
 
     fun addMembers(addresses: List<String>) {
-        runBlocking { libXMTPGroup.addMembers(addresses) }
+        try {
+            runBlocking { libXMTPGroup.addMembers(addresses) }
+        } catch (e: Exception) {
+            throw XMTPException("User does not have permissions", e)
+        }
     }
 
     fun removeMembers(addresses: List<String>) {
-        runBlocking { libXMTPGroup.removeMembers(addresses) }
+        try {
+            runBlocking { libXMTPGroup.removeMembers(addresses) }
+        } catch (e: Exception) {
+            throw XMTPException("User does not have permissions", e)
+        }
     }
 
     fun memberAddresses(): List<String> {