add test on can message

Author: nplasterer

library/src/androidTest/java/org/xmtp/android/library/GroupTest.kt

@@ -4,6 +4,7 @@ import androidx.test.ext.junit.runners.AndroidJUnit4
 import androidx.test.platform.app.InstrumentationRegistry
 import kotlinx.coroutines.runBlocking
 import org.junit.Assert.assertEquals
+import org.junit.Assert.assertThrows
 import org.junit.Before
 import org.junit.Test
 import org.junit.runner.RunWith
@@ -127,6 +128,32 @@ class GroupTest {
         assertEquals(convos.size, 3)
     }
 
+    @Test
+    fun testCannotSendMessageToGroupMemberNotOnV3() {
+        var fakeApiClient = FakeApiClient()
+        val chuxAccount = PrivateKeyBuilder()
+        val chux: PrivateKey = chuxAccount.getPrivateKey()
+        val chuxClient: Client = Client().create(account = chuxAccount, apiClient = fakeApiClient)
+
+        assertThrows("Recipient not on network", XMTPException::class.java) {
+            boClient.conversations.newGroup(listOf(chux.walletAddress))
+        }
+    }
+
+    @Test
+    fun testCannotStartGroupWithSelf() {
+        assertThrows("Recipient is sender", XMTPException::class.java) {
+            boClient.conversations.newGroup(listOf(bo.walletAddress))
+        }
+    }
+
+    @Test
+    fun testCannotStartEmptyGroupChat() {
+        assertThrows("Cannot start an empty group chat.", XMTPException::class.java) {
+            boClient.conversations.newGroup(listOf())
+        }
+    }
+
     @Test
     fun testCanSendMessageToGroup() {
         val group = boClient.conversations.newGroup(listOf(alix.walletAddress))

library/src/main/java/org/xmtp/android/library/Client.kt

@@ -559,6 +559,12 @@ class Client() {
         return runBlocking { query(Topic.contact(peerAddress)).envelopesList.size > 0 }
     }
 
+    fun canMessage(addresses: List<String>): Boolean {
+        return runBlocking {
+            libXMTPClient != null && !libXMTPClient!!.canMessage(addresses).contains(false)
+        }
+    }
+
     val privateKeyBundle: PrivateKeyBundle
         get() = PrivateKeyBundleBuilder.buildFromV1Key(privateKeyBundleV1)
 

library/src/main/java/org/xmtp/android/library/Conversations.kt

@@ -95,8 +95,7 @@ data class Conversations(
         ) {
             throw XMTPException("Recipient is sender")
         }
-        val contacts = accountAddresses.map { client.contacts.find(it) }
-        if (contacts.size != accountAddresses.size) {
+        if (!client.canMessage(accountAddresses)) {
             throw XMTPException("Recipient not on network")
         }