Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy sign method #171

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Remove legacy sign method #171

merged 6 commits into from
Feb 5, 2024

Conversation

nplasterer
Copy link
Contributor

@nplasterer nplasterer commented Feb 5, 2024 •
edited
Loading

This removes the legacySign method introduced in a previous PR to just get the bytes of the signature out of the previous sign method to limit breaking changes.

@nplasterer nplasterer self-assigned this Feb 5, 2024
@nplasterer nplasterer marked this pull request as ready for review February 5, 2024 20:57
@nplasterer nplasterer requested a review from a team as a code owner February 5, 2024 20:57
cameronvoell
cameronvoell approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified this allows react-native main branch to build immediately with the branch here. looks good!

@nplasterer nplasterer merged commit 8a019c7 into main Feb 5, 2024
5 of 6 checks passed
@nplasterer nplasterer deleted the np/remove-legacy-sign branch February 5, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronvoell cameronvoell cameronvoell approved these changes

Assignees

@nplasterer nplasterer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nplasterer @cameronvoell