Add isActive to Groups #176
Merged
+80
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplasterer
commented
Feb 13, 2024
nplasterer
commented
Feb 13, 2024
neekolas
approved these changes
Feb 13, 2024
richardhuaaa
approved these changes
Feb 13, 2024
| @@ -413,6 +413,8 @@ internal interface _UniFFILib : Library { | |||
| ): RustBuffer.ByValue | |||
There was a problem hiding this comment.
There should have been a libxmtp-version.txt generated alongside the .kt definition, could we check that in too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check to see if the group is active or if the member has been removed so that we can update the UI accordingly.
This also adds libxmtp versioning to help with debugging and fixes a client creation issue.