feat: integrate `shouldPush' for React Native #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
nplasterer
approved these changes
Feb 20, 2024
nplasterer
merged commit 887f1f4
into
gg/enhancement/add_sender_hmac_to_message_v2
0 of 3 checks passed
|
@kele-leanes when I merged this PR into the base PR a bunch of stuff broke. Do you mind fixing that? Looks like you need to update the shouldPush method in a couple more places for decryptedMessages |
kele-leanes
pushed a commit
that referenced
this pull request
Feb 28, 2024
This reverts commit 887f1f4.
kele-leanes
pushed a commit
that referenced
this pull request
Feb 28, 2024
* Add shouldPush property to SendOptions * Add shouldPush property to DecryptedMessage class * Add shouldPush parameter to ConversationV2 and MessageV2Builder
kele-leanes
pushed a commit
that referenced
this pull request
Feb 28, 2024
This reverts commit 887f1f4.
nplasterer
added a commit
that referenced
this pull request
Mar 1, 2024
* Adding the way for adding should push and hmac * Adding new approach for codecs and crypto * Solving test for conversation using new flag * Update ConversationV2.kt * do kotlin way of extending proto class * Adding the proper way to manage the codec changes * Update GroupMembershipChangeCodec.kt * Update library/src/main/java/org/xmtp/android/library/Crypto.kt Co-authored-by: Brendan McMillion <brendanmcmillion@gmail.com> * Update library/src/main/java/org/xmtp/android/library/Crypto.kt Co-authored-by: Brendan McMillion <brendanmcmillion@gmail.com> * Update library/src/main/java/org/xmtp/android/library/Crypto.kt Co-authored-by: Brendan McMillion <brendanmcmillion@gmail.com> * add method to get the hmac keys * fix up the crypto * add the get keys code for hmacs * remove unneeded crypto code * write a test for it * get the test to pass * feat: integrate `shouldPush' for React Native (#184) * Add shouldPush property to SendOptions * Add shouldPush property to DecryptedMessage class * Add shouldPush parameter to ConversationV2 and MessageV2Builder * Update GroupMembershipChangeTest.kt * Removing issues and failing tests * Update GroupMembershipChangeTest.kt * Updating shouldPush flag and removing issues in instrumental testing * Ignoring failing tests * remove all the ignored tests * feat: add shouldPush property to MessageV2Builder * fix up the lint issue * fix: deriveKey function and improvements * fix: getHmacKeys method * fix: CodecText.kt * Revert "feat: integrate `shouldPush' for React Native (#184)" This reverts commit 887f1f4. * Revert "Removing issues and failing tests" This reverts commit e6cecc7. * Remove @ignore annotations from GroupTest --------- Co-authored-by: Giovani Gonzalez <darkgeat@gmail.com> Co-authored-by: Naomi Plasterer <naomi@xmtp.com> Co-authored-by: Brendan McMillion <brendanmcmillion@gmail.com> Co-authored-by: Ezequiel Leanes <ezequiel.leanes@distillery.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Accept
shouldPushas a parameter from RN