Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump consent pagination #224

Merged
merged 6 commits into from
Apr 12, 2024
Merged

Bump consent pagination #224

merged 6 commits into from
Apr 12, 2024

Conversation

nplasterer
Copy link
Contributor

@nplasterer nplasterer commented Apr 12, 2024

This bumps the consent record pagination size to 500 instead of the previous 100. Should help with performance of the subscribe feature.

Previously

Loaded 7561 consent envelopes in 8.542s
Loaded 1102 consent entries in 2.429s
Second time loaded 0 consent envelopes in 0.09s
Second time loaded 1102 consent entries in 0s

Now

Loaded 7561 consent envelopes in 5.011s
Loaded 1102 consent entries in 2.264s
Second time loaded 0 consent envelopes in 0.102s
Second time loaded 1102 consent entries in 0s

@nplasterer nplasterer self-assigned this Apr 12, 2024
@nplasterer nplasterer marked this pull request as ready for review April 12, 2024 20:28
@nplasterer nplasterer requested a review from a team as a code owner April 12, 2024 20:28
}.build()
}
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was dead code

@nplasterer nplasterer merged commit fe5b6e0 into main Apr 12, 2024
5 of 6 checks passed
@nplasterer nplasterer deleted the np/bump-consent-page branch April 12, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants