Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractXnioSocketChannel.doWrite does not handle FileRegion #14

Open
fl4via opened this issue Sep 10, 2019 · 1 comment
Open

AbstractXnioSocketChannel.doWrite does not handle FileRegion #14

fl4via opened this issue Sep 10, 2019 · 1 comment

Comments

@fl4via
Copy link
Contributor

fl4via commented Sep 10, 2019

The reason for this is that unexpectedly ChannelOutboundBuffer.nioBuffers returns a non null array when there are FileRegion messages in the outbound internal entries.
Since doWrite relies on nioBuffers returning null if there are non ByteBuf messages, it throws a ClassCastException.
fl4via added a commit to fl4via/netty-xnio-transport that referenced this issue Sep 10, 2019
@fl4via
xnio#14 At AbstractXnioSocketChannel.doWrite, skip loop if there is a…
a6aca4a 
… non BytBuf message to handle it properly
fl4via added a commit to fl4via/netty-xnio-transport that referenced this issue Sep 10, 2019
@fl4via
xnio#14 At AbstractXnioSocketChannel.doWrite, skip loop if there is a…
d364493 
… non BytBuf message to handle it properly
fl4via added a commit to fl4via/netty-xnio-transport that referenced this issue Sep 10, 2019
@fl4via
xnio#14 At AbstractXnioSocketChannel.doWrite, skip loop if there is a…
27311c0 
… non BytBuf message to handle it properly
fl4via added a commit to fl4via/netty-xnio-transport that referenced this issue Sep 10, 2019
@fl4via
xnio#14 At AbstractXnioSocketChannel.doWrite, skip loop if there is a…
38bd31c 
… non BytBuf message to handle it properly
fl4via added a commit to fl4via/netty-xnio-transport that referenced this issue Sep 10, 2019
@fl4via
xnio#14 At AbstractXnioSocketChannel.doWrite, skip loop if there is a…
8095cc9 
… non BytBuf message to handle it properly
jmesnil added a commit that referenced this issue Sep 10, 2019
@jmesnil
Merge pull request #16 from fl4via/master
c0bbe34 
#14 At AbstractXnioSocketChannel.doWrite, skip loop if there is a…
jmesnil added a commit that referenced this issue Sep 10, 2019
@jmesnil
Merge pull request #15 from fl4via/0.1
fdd89f7 
#14 At AbstractXnioSocketChannel.doWrite, skip loop if there is a…
@fl4via
Copy link
Contributor Author

fl4via commented Sep 10, 2019

@normanmaurer maybe you will have a say in this. Right now we fixed the problem at netty-xnio-transport, but shouldn't nioBuffers return null if it finds a FileRegion message? Right now it doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fl4via