Skip to content

Commit d7a8b1b

Browse files
author
bnu
committed
Merge branch 'release/1.8.10'
2 parents e9339d4 + 02873a3 commit d7a8b1b

File tree

4 files changed

+63
-39
lines changed

4 files changed

+63
-39
lines changed

config/config.inc.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
/**
3030
* Display XE's full version.
3131
*/
32-
define('__XE_VERSION__', '1.8.9');
32+
define('__XE_VERSION__', '1.8.10');
3333
define('__XE_VERSION_ALPHA__', (stripos(__XE_VERSION__, 'alpha') !== false));
3434
define('__XE_VERSION_BETA__', (stripos(__XE_VERSION__, 'beta') !== false));
3535
define('__XE_VERSION_RC__', (stripos(__XE_VERSION__, 'rc') !== false));

modules/editor/components/image_gallery/image_gallery.class.php

+11-5
Original file line numberDiff line numberDiff line change
@@ -43,18 +43,24 @@ function getPopupContent()
4343
*/
4444
function transHTML($xml_obj)
4545
{
46-
$gallery_info = new stdClass;
47-
$gallery_info->srl = rand(111111,999999);
48-
$gallery_info->border_thickness = $xml_obj->attrs->border_thickness;
46+
$gallery_info = new stdClass();
47+
$gallery_info->srl = rand(111111, 999999);
48+
$gallery_info->border_thickness = (int)$xml_obj->attrs->border_thickness;
4949
$gallery_info->gallery_style = $xml_obj->attrs->gallery_style;
5050
$color_preg = "/^([a-fA-F0-9]{6})/";
5151
$gallery_info->border_color = preg_replace($color_preg,"#$1",$xml_obj->attrs->border_color);
5252
$gallery_info->bg_color = preg_replace($color_preg,"#$1",$xml_obj->attrs->bg_color);
5353
$gallery_info->gallery_align = $xml_obj->attrs->gallery_align;
5454

55+
if(!in_array($gallery_info->gallery_align, array('left', 'center', 'right'))) {
56+
$gallery_info->gallery_align = 'center';
57+
}
58+
5559
$images_list = $xml_obj->attrs->images_list;
56-
$images_list = preg_replace('/\.(gif|jpg|jpeg|png) /i',".\\1\n",$images_list);
57-
$gallery_info->images_list = explode("\n",trim($images_list));
60+
$images_list = preg_replace('/\.(gif|jpe?g|png) /i', ".\\1\n", $images_list);
61+
$images_list = explode("\n", trim($images_list));
62+
$gallery_info->images_list = preg_grep("/^[a-z0-9\/]+\.(gif|jpe?g|png)+$/", $images_list);
63+
5864
// If you set the output to output the XML code generated a list of the image
5965
if(Context::getResponseMethod() == 'XMLRPC')
6066
{

modules/menu/menu.admin.controller.php

+47-31
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ public function addMenu($title, $siteSrl = 0)
103103
$output->add('menuSrl', $args->menu_srl);
104104
return $output;
105105
}
106-
106+
107107
function linkAllModuleInstancesToSitemap()
108108
{
109109
$unlinked_modules = false;
@@ -114,15 +114,15 @@ function linkAllModuleInstancesToSitemap()
114114
{
115115
$unlinked_modules = $output->data;
116116
}
117-
117+
118118
if($unlinked_modules)
119119
{
120120
$unlinked_menu_srl = $this->getUnlinkedMenu();
121121
$output = $this->updateLinkModule($unlinked_modules, $unlinked_menu_srl);
122122
}
123123

124124
}
125-
125+
126126
function getUnlinkedMenu()
127127
{
128128
// 'unlinked' menu 존재여부 확인
@@ -139,7 +139,7 @@ function getUnlinkedMenu()
139139
unset($moduleConfig->unlinked_menu_srl);
140140
}
141141
}
142-
142+
143143
if(!$moduleConfig->unlinked_menu_srl)
144144
{
145145
$output = $this->addMenu('unlinked', 0);
@@ -154,10 +154,10 @@ function getUnlinkedMenu()
154154
return false;
155155
}
156156
}
157-
157+
158158
return $moduleConfig->unlinked_menu_srl;
159159
}
160-
160+
161161
/**
162162
* insert menu when not linked module.
163163
*
@@ -172,17 +172,17 @@ function updateLinkModule($moduleInfos, $menuSrl)
172172
{
173173
return new Object(-1, 'msg_invalid_request');
174174
}
175-
175+
176176
foreach($moduleInfos as $moduleInfo)
177177
{
178178
// search menu.
179179
$args = new stdClass;
180180
$args->url = $moduleInfo->mid;
181181
$args->site_srl = $moduleInfo->site_srl;
182182
$args->is_shortcut = 'N';
183-
183+
184184
$output = executeQuery('menu.getMenuItemByUrl', $args);
185-
185+
186186
if($output->toBool() && $output->data)
187187
{
188188
$moduleInfo->menu_srl = $output->data->menu_srl;
@@ -195,17 +195,17 @@ function updateLinkModule($moduleInfos, $menuSrl)
195195
$item_args->name = $moduleInfo->mid;
196196
$item_args->menu_item_srl = getNextSequence();
197197
$item_args->listorder = -1*$item_args->menu_item_srl;
198-
198+
199199
$output = executeQuery('menu.insertMenuItem', $item_args);
200200
if(!$output->toBool())
201201
{
202202
return $output;
203203
}
204204
$moduleInfo->menu_srl = $menuSrl;
205205
}
206-
206+
207207
$output = executeQuery('module.updateModule', $moduleInfo);
208-
208+
209209
return $output;
210210
}
211211

@@ -214,14 +214,14 @@ function updateLinkModule($moduleInfos, $menuSrl)
214214
{
215215
$oCacheHandler->invalidateGroupKey('site_and_module');
216216
}
217-
217+
218218
$oMenuAdminController = getAdminController('menu');
219219
$oMenuAdminController->makeXmlFile($menuSrl);
220-
220+
221221
return new Object();
222222
}
223-
224-
223+
224+
225225

226226
/**
227227
* Change the menu title
@@ -418,7 +418,7 @@ public function procMenuAdminInsertItem($request = NULL)
418418

419419
// recreate menu cache file
420420
$this->makeXmlFile($request->menu_srl);
421-
421+
422422
if(!$isProc)
423423
{
424424
return $this->get('menu_item_srl');
@@ -504,7 +504,7 @@ private function _insertShortcut(&$request)
504504
$args->is_shortcut = $request->is_shortcut;
505505
$args->url = '#';
506506
}
507-
507+
508508
if($request->menu_desc) $args->desc = $request->menu_desc;
509509
else $args->desc = '';
510510

@@ -539,10 +539,13 @@ private function _insertMenu(&$request, $isProc)
539539

540540
if($request->menu_name_key) $args->name = $request->menu_name_key;
541541
else $args->name = $request->menu_name;
542-
542+
543543
if($request->menu_desc) $args->desc = $request->menu_desc;
544544
else $args->desc = '';
545545

546+
$args->name = strip_tags(removeHackTag($args->name));
547+
$args->desc = strip_tags(removeHackTag($args->desc));
548+
debugPrint($args);
546549
if($request->module_id && strncasecmp('http', $request->module_id, 4) === 0)
547550
{
548551
return new Object(-1, 'msg_invalid_request');
@@ -616,7 +619,7 @@ private function _insertModule(&$request, &$args)
616619
{
617620
$cmArgs->use_mobile = 'Y';
618621
}
619-
622+
620623
// if mid is empty, auto create mid
621624
if(!$request->module_id)
622625
{
@@ -646,7 +649,7 @@ private function _insertModule(&$request, &$args)
646649
public function procMenuAdminUpdateItem()
647650
{
648651
$request = Context::getRequestVars();
649-
652+
debugPrint($request);
650653
if(!$request->menu_item_srl || !$request->menu_name)
651654
{
652655
return new Object(-1, 'msg_invalid_request');
@@ -725,14 +728,17 @@ public function procMenuAdminUpdateItem()
725728
{
726729
$args->name = $request->menu_name;
727730
}
728-
731+
729732
if($request->menu_desc) $args->desc = $request->menu_desc;
730733
else $args->desc = '';
731-
734+
735+
$args->name = removeHackTag($args->name);
736+
$args->desc = removeHackTag($args->desc);
737+
732738
unset($args->group_srls);
733739
$args->open_window = $request->menu_open_window;
734740
$args->expand = $request->menu_expand;
735-
$output = executeQuery('menu.updateMenuItem', $args);
741+
$output = $this->_updateMenuItem($args);
736742

737743
$this->makeXmlFile($args->menu_srl);
738744

@@ -790,21 +796,31 @@ public function procMenuAdminButtonUpload()
790796
$item_info->active_btn = '';
791797
}
792798

793-
$output = executeQuery('menu.updateMenuItem', $item_info);
799+
$output = $this->_updateMenuItem($item_info);
794800

795801
// recreate menu cache file
796802
$this->makeXmlFile($args->menu_srl);
797803
}
798804

799805
public function updateMenuItem($itemInfo)
800806
{
801-
$output = executeQuery('menu.updateMenuItem', $itemInfo);
807+
$output = $this->_updateMenuItem($itemInfo);
802808

803809
// recreate menu cache file
804810
$this->makeXmlFile($itemInfo->menu_srl);
805811
return $output;
806812
}
807813

814+
public function _updateMenuItem($itemInfo)
815+
{
816+
$itemInfo->name = removeHackTag($itemInfo->name);
817+
$itemInfo->desc = removeHackTag($itemInfo->desc);
818+
819+
$output = executeQuery('menu.updateMenuItem', $itemInfo);
820+
821+
return $output;
822+
}
823+
808824
/**
809825
* Delete menu item(menu of the menu)
810826
* @return void|Object
@@ -961,7 +977,7 @@ private function _deleteMenuItem(&$oDB, &$menuInfo, $node)
961977
{
962978
$output->data->url = '';
963979
$referenceItem = $output->data;
964-
$output = executeQuery('menu.updateMenuItem', $referenceItem);
980+
$output = $this->_updateMenuItem($referenceItem);
965981
if(!$output->toBool())
966982
{
967983
$oDB->rollback();
@@ -1085,7 +1101,7 @@ private function _recursiveUpdateMenuItem($node, $menu_srl)
10851101
$args = new stdClass();
10861102
$args->menu_srl = $menu_srl;
10871103
$args->menu_item_srl = $node['node_srl'];
1088-
$output = executeQuery('menu.updateMenuItemNode', $args);
1104+
$output = $this->_updateMenuItem($args);
10891105

10901106
//module's menu_srl move also
10911107
if($node['is_shortcut'] == 'N' && !empty($node['url']))
@@ -1249,7 +1265,7 @@ private function _copyMenu($menuSrl, $parentSrl, &$originMenu)
12491265
$update_item_info->normal_btn = $copied_info['normal_btn'];
12501266
$update_item_info->hover_btn = $copied_info['hover_btn'];
12511267
$update_item_info->active_btn = $copied_info['active_btn'];
1252-
executeQuery('menu.updateMenuItem', $update_item_info);
1268+
$output = $this->_updateMenuItem($update_item_info);
12531269
}
12541270
$this->insertedMenuItemSrlList[] = $insertedMenuItemSrl;
12551271
}
@@ -1629,7 +1645,7 @@ function procMenuAdminInsertItemForAdminMenu()
16291645
// Update if exists
16301646
if($item_info->menu_item_srl == $args->menu_item_srl)
16311647
{
1632-
$output = executeQuery('menu.updateMenuItem', $args);
1648+
$output = $this->_updateMenuItem($args);
16331649
if(!$output->toBool()) return $output;
16341650
}
16351651
// Insert if not exist
@@ -1680,7 +1696,7 @@ public function procMenuAdminUpdateAuth()
16801696
if($exposure) $args->group_srls = implode(',', $exposure);
16811697
}
16821698

1683-
$output = executeQuery('menu.updateMenuItem', $args);
1699+
$output = $this->_updateMenuItem($args);
16841700
if(!$output->toBool())
16851701
{
16861702
return $output;

modules/module/module.controller.php

+4-2
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ function insertModule($args)
462462
$menuArgs->url = $args->mid;
463463
$menuArgs->expand = 'N';
464464
$menuArgs->is_shortcut = 'N';
465-
$menuArgs->name = $args->browser_title;
465+
$menuArgs->name = removeHackTag($args->browser_title);
466466
$menuArgs->listorder = $args->menu_item_srl * -1;
467467

468468
$menuItemOutput = executeQuery('menu.insertMenuItem', $menuArgs);
@@ -476,8 +476,9 @@ function insertModule($args)
476476
}
477477
}
478478

479-
$args->menu_srl = $menuArgs->menu_srl;
480479
// Insert a module
480+
$args->menu_srl = $menuArgs->menu_srl;
481+
$args->browser_title = removeHackTag($args->browser_title);
481482
$output = executeQuery('module.insertModule', $args);
482483
if(!$output->toBool())
483484
{
@@ -520,6 +521,7 @@ function updateModule($args)
520521
if(!$args->site_srl) $args->site_srl = (int)$module_info->site_srl;
521522
if(!$args->browser_title) $args->browser_title = $module_info->browser_title;
522523
}
524+
$args->browser_title = removeHackTag($args->browser_title);
523525

524526
$output = executeQuery('module.isExistsModuleName', $args);
525527
if(!$output->toBool() || $output->data->count)

0 commit comments

Comments
 (0)