XCOMMONS-3330: Job groups with several threads may not return a current job #1329
Conversation
…nt job * Store several current jobs. * Add a new possibility to return all running jobs of a job group. * Deprecate the old method that returns just a single running job. * Clean up empty entries in groupedJobs. * Some code cleanup.
| return executor != null ? executor.currentJob : null; | ||
| if (executor != null) { | ||
| // Return an unmodifiable copy of the set of currently running jobs. | ||
| return Collections.unmodifiableCollection(new ArrayList<>(executor.currentJobs)); |
There was a problem hiding this comment.
It's not clear to me why you create an ArrayList. Isn't Collections.unmodifiableCollection enough to make the set readonly ?
There was a problem hiding this comment.
I want to avoid that the collection updates when jobs are started or stopped. I would expect that we expose this method in a script service and I don't want to let the author of a Velocity script deal with the fact that directly after isEmpty() returns false, there might not be any elements anymore in the collection.
We could also let this return a List, this might make things more explicit what to expect in terms of the different operations?
There was a problem hiding this comment.
I want to avoid that the collection updates when jobs are started or stopped.
Very good point indeed.
We could also let this return a List, this might make things more explicit what to expect in terms of the different operations?
Why not.
There was a problem hiding this comment.
Done. I also found and fixed some issues in the implementations for constructing the list both in the default and in the actual implementation.
…nt job * Change the API to return a List for the current jobs. * Fix not returning a list with a null value in the default implementation. * Fix synchronization on the set for iterating over it.
Jira URL
https://jira.xwiki.org/browse/XCOMMONS-3330
Changes
Description
Clarifications
Screenshots & Video
No UI changes.
Executed Tests
Expected merging strategy