Skip to content

Commit d9fc599

Browse files
committed
[misc] Fix the xwiki.extension.features and also indicate the previous extension id.
1 parent 7b62e9d commit d9fc599

File tree

3 files changed

+19
-9
lines changed
  • xwiki-platform-core/xwiki-platform-ckeditor
    • xwiki-platform-ckeditor-plugins
    • xwiki-platform-ckeditor-ui
    • xwiki-platform-ckeditor-webjar

3 files changed

+19
-9
lines changed

xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@
3434
<properties>
3535
<!-- Name to display by the Extension Manager -->
3636
<xwiki.extension.name>CKEditor Plugins for XWiki</xwiki.extension.name>
37+
<!-- This module has been moved from XWiki Contrib to platform. -->
38+
<xwiki.extension.previousIds>org.xwiki.contrib:application-ckeditor-plugins</xwiki.extension.previousIds>
3739
<!-- Old name of this module used for retro compatibility when resolving dependencies of old extensions -->
3840
<xwiki.extension.features>org.xwiki.contrib:application-ckeditor-plugins</xwiki.extension.features>
3941
</properties>

xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-ui/pom.xml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,13 @@
3434
<properties>
3535
<!-- Name to display by the Extension Manager -->
3636
<xwiki.extension.name>CKEditor Integration</xwiki.extension.name>
37-
<!-- Don't run Revapi here because there's no Java code. -->
38-
<xwiki.revapi.skip>true</xwiki.revapi.skip>
37+
<!-- This module has been moved from XWiki Contrib to platform. -->
38+
<xwiki.extension.previousIds>org.xwiki.contrib:application-ckeditor-ui</xwiki.extension.previousIds>
3939
<!-- Old name of this module used for retro compatibility when resolving dependencies of old extensions -->
4040
<xwiki.extension.features>org.xwiki.contrib:application-ckeditor-ui</xwiki.extension.features>
41+
42+
<!-- Don't run Revapi here because there's no Java code. -->
43+
<xwiki.revapi.skip>true</xwiki.revapi.skip>
4144
</properties>
4245

4346
<dependencies>

xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-webjar/pom.xml

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,18 @@
3434
<properties>
3535
<!-- Name to display by the Extension Manager -->
3636
<xwiki.extension.name>CKEditor WebJar</xwiki.extension.name>
37-
<!-- Old name of this module used for retro compatibility when resolving dependencies of old extensions -->
38-
<xwiki.extension.features>org.xwiki.contrib:application-ckeditor-webjar</xwiki.extension.features>
39-
<!-- We bundle the CKEditor code. -->
40-
<xwiki.extension.features>org.webjars:ckeditor</xwiki.extension.features>
41-
<xwiki.extension.features>org.webjars.npm:ckeditor</xwiki.extension.features>
42-
<!-- See https://www.npmjs.com/package/ckeditor4 -->
43-
<xwiki.extension.features>ckeditor4</xwiki.extension.features>
37+
<!-- This module has been moved from XWiki Contrib to platform. -->
38+
<xwiki.extension.previousIds>org.xwiki.contrib:application-ckeditor-webjar</xwiki.extension.previousIds>
39+
<!-- The list of extensions that this module either replaces or bundles:
40+
* this module replaces the CKEditor Integration WebJar extension from XWiki Contrib
41+
* this module bundles the CKEditor code (so it can be seen as a replacement for both the CKEditor default WebJar
42+
and the CKEditor node module) -->
43+
<xwiki.extension.features>
44+
org.xwiki.contrib:application-ckeditor-webjar,
45+
org.webjars:ckeditor/${ckeditor.version},
46+
org.webjars.npm:ckeditor/${ckeditor.version},
47+
ckeditor4/${ckeditor.version}
48+
</xwiki.extension.features>
4449

4550
<!-- The path to the folder where we clone the CKEditor sources. -->
4651
<ckeditor.path>${project.build.directory}/ckeditor4-${ckeditor.version}</ckeditor.path>

0 commit comments

Comments
 (0)