Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong handling of field PCDF_VALUE='P' : required bytes are missing in the encoded binary for a TC #4

Open
WilfridGonzalez opened this issue Apr 14, 2023 · 0 comments

Comments

@WilfridGonzalez
Copy link

WilfridGonzalez commented Apr 14, 2023

The scos2k ICD provides the following meaning of value PCDF_VALUE='P'
‘P’ - Other packet parameter whose value is automatically set by the SCOS-2000 command subsystem (e.g. packet length, source sequence counters).

The current implementation in org/yamcs/scos2k/TcMibLoader.java silently ignores this case, and thus the bytes corresponding to the parameters are missing in the encoded binary, leaving no place for a dedicated CommandPostProcessor to compute the bytes.
The bug was discovered when trying to encode CSSDS PUS TC with a secondary header for which the Source ID field was declared of PCDF_TYPE='P' in the database extract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant