Handle multiple identical diagnostics in YcmShowDetailedDiagnostic popup

If a line for which detailed diagnostics are requested contains
more than a single diagnostic with the same message, YCM will try
`options.pop( 'col' )` more than once.

We do not need to really iterate through the diagnostics once we have
found the first one that is a match. If there's only one diag with the
matching message, looping beyond that diagnostic is just a waste of
time. If there's multiple diagnostics with the same message, it does not
matter which one we display in the popup.

Hence, the added break at the end of the loop.

Author: bstaletic

python/ycm/youcompleteme.py

@@ -868,6 +868,7 @@ def ShowDetailedDiagnostic( self, message_in_popup ):
               'textprop': prop[ 'type' ],
             } )
             options.pop( 'col' )
+            break
         vim.eval( f'{ popup_func }( { json.dumps( lines ) }, '
                                   f'{ json.dumps( options ) } )' )
       else:

test/diagnostics.test.vim

@@ -446,3 +446,21 @@ function! Test_ShowDetailedDiagnostic_Popup_MultilineDiagFromStartOfLine()
 
   %bwipe!
 endfunction
+
+function! Test_ShowDetailedDiagnostic_Popup_MultipleDiagsPerLine_SameMessage()
+  let f = tempname() . '.cc'
+  execut 'edit' f
+  call setline( 1, [ 'void f(){a;a;}', ] )
+  call youcompleteme#test#setup#WaitForInitialParse( {} )
+
+  call WaitForAssert( {->
+    \ assert_true(
+      \ py3eval(
+        \ 'len( ycm_state.CurrentBuffer()._diag_interface._diagnostics )'
+    \ ) ) } )
+
+  YcmShowDetailedDiagnostic popup
+  call assert_equal( 1, len( popup_list() ) )
+  call feedkeys( "i\<Esc>", 'xt' )
+  call assert_equal( 0, len( popup_list() ) )
+endfunction