Skip to content

Commit 5f9dbe8

Browse files
authored
Refactoring after PR 16190: rename schemeshard_export_scheme_uploader.h, implement fallback class for export metadata uploader (#16343)
1 parent 330692d commit 5f9dbe8

File tree

4 files changed

+31
-3
lines changed

4 files changed

+31
-3
lines changed

ydb/core/tx/schemeshard/schemeshard_export__create.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
#include "schemeshard_export.h"
44
#include "schemeshard_export_flow_proposals.h"
55
#include "schemeshard_export_helpers.h"
6-
#include "schemeshard_export_scheme_uploader.h"
6+
#include "schemeshard_export_uploaders.h"
77
#include "schemeshard_audit_log.h"
88
#include "schemeshard_impl.h"
99

ydb/core/tx/schemeshard/schemeshard_export_scheme_uploader.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#include "schemeshard.h"
2-
#include "schemeshard_export_scheme_uploader.h"
2+
#include "schemeshard_export_uploaders.h"
33

44
#include <ydb/core/backup/common/encryption.h>
55
#include <ydb/core/protos/flat_scheme_op.pb.h>

ydb/core/tx/schemeshard/schemeshard_export_scheme_uploader_fallback.cpp

Lines changed: 29 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#include "schemeshard_export_scheme_uploader.h"
1+
#include "schemeshard_export_uploaders.h"
22

33
#include <ydb/core/tx/schemeshard/schemeshard_private.h>
44
#include <ydb/library/actors/core/actor_bootstrapped.h>
@@ -29,6 +29,27 @@ class TSchemeUploaderFallback: public TActorBootstrapped<TSchemeUploaderFallback
2929
ui32 ItemIdx;
3030
};
3131

32+
class TExportMetadataUploaderFallback: public TActorBootstrapped<TExportMetadataUploaderFallback> {
33+
public:
34+
TExportMetadataUploaderFallback(
35+
TActorId schemeShard,
36+
ui64 exportId
37+
)
38+
: SchemeShard(schemeShard)
39+
, ExportId(exportId)
40+
{
41+
}
42+
43+
void Bootstrap() {
44+
Send(SchemeShard, new TEvPrivate::TEvExportUploadMetadataResult(ExportId, false, "Exports to S3 are disabled"));
45+
PassAway();
46+
}
47+
48+
private:
49+
TActorId SchemeShard;
50+
ui64 ExportId;
51+
};
52+
3253

3354
IActor* CreateSchemeUploader(TActorId schemeShard, ui64 exportId, ui32 itemIdx, TPathId sourcePathId,
3455
const Ydb::Export::ExportToS3Settings& settings, const TString& databaseRoot, const TString& metadata,
@@ -38,4 +59,11 @@ IActor* CreateSchemeUploader(TActorId schemeShard, ui64 exportId, ui32 itemIdx,
3859
return new TSchemeUploaderFallback(schemeShard, exportId, itemIdx);
3960
}
4061

62+
NActors::IActor* CreateExportMetadataUploader(NActors::TActorId schemeShard, ui64 exportId,
63+
const Ydb::Export::ExportToS3Settings& settings, const NKikimrSchemeOp::TExportMetadata& exportMetadata
64+
) {
65+
Y_UNUSED(settings, exportMetadata);
66+
return new TExportMetadataUploaderFallback(schemeShard, exportId);
67+
}
68+
4169
} // NKikimr::NSchemeShard

0 commit comments

Comments
 (0)