Skip to content

viewer: change auth for whoami and capabilities handlers #17942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2025

Conversation

StekPerepolnen
Copy link
Collaborator

@StekPerepolnen StekPerepolnen commented Apr 30, 2025

Changelog entry

viewer: change auth for whoami and capabilities handlers

Changelog category

  • User Interface

Description for reviewers

Changing auth for whoami is required for database list dispaying

@StekPerepolnen StekPerepolnen changed the title whoami no auth viewer: don't use auth for whoami handlers Apr 30, 2025
@github-actions github-actions bot added ui and removed ui labels Apr 30, 2025
@StekPerepolnen StekPerepolnen changed the title viewer: don't use auth for whoami handlers viewer: don't use auth for whoami handler Apr 30, 2025
@github-actions github-actions bot added ui and removed ui labels Apr 30, 2025
Copy link

github-actions bot commented Apr 30, 2025

🟢 2025-05-05 15:19:51 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Apr 30, 2025

2025-04-30 21:09:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4c61473 has started.
2025-04-30 21:09:17 UTC Artifacts will be uploaded here
2025-04-30 21:12:02 UTC ya make is running...
🟡 2025-04-30 22:17:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20105 18743 0 3 1324 35

2025-04-30 22:19:27 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-30 22:34:17 UTC ydbd size 2.2 GiB changed* by +89.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 093c931 merge: 4c61473 diff diff %
ydbd size 2 343 326 616 Bytes 2 343 418 600 Bytes +89.8 KiB +0.004%
ydbd stripped size 492 724 288 Bytes 492 746 816 Bytes +22.0 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2025-04-30 22:34:18 UTC Check cancelled

Copy link

github-actions bot commented Apr 30, 2025

2025-04-30 21:09:22 UTC Pre-commit check linux-x86_64-release-asan for 4c61473 has started.
2025-04-30 21:09:33 UTC Artifacts will be uploaded here
2025-04-30 21:12:26 UTC ya make is running...

@StekPerepolnen StekPerepolnen marked this pull request as ready for review April 30, 2025 21:13
@StekPerepolnen StekPerepolnen requested a review from a team as a code owner April 30, 2025 21:13
@github-actions github-actions bot added ui and removed ui labels Apr 30, 2025
Copy link

github-actions bot commented Apr 30, 2025

2025-04-30 22:41:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for 37d5cda has started.
2025-04-30 22:41:58 UTC Artifacts will be uploaded here
2025-04-30 22:44:48 UTC ya make is running...
🟡 2025-04-30 23:47:39 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20105 18729 0 4 1335 37

2025-04-30 23:49:16 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-01 00:25:07 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
240 (only retried tests) 210 0 0 0 30

🟢 2025-05-01 00:25:13 UTC Build successful.
🟢 2025-05-01 00:25:32 UTC ydbd size 2.2 GiB changed* by +11.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1b7b16b merge: 37d5cda diff diff %
ydbd size 2 343 417 512 Bytes 2 343 429 672 Bytes +11.9 KiB +0.001%
ydbd stripped size 492 746 368 Bytes 492 747 968 Bytes +1.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Apr 30, 2025

2025-04-30 22:42:18 UTC Pre-commit check linux-x86_64-release-asan for 37d5cda has started.
2025-04-30 22:42:28 UTC Artifacts will be uploaded here
2025-04-30 22:45:10 UTC ya make is running...
🟡 2025-05-01 00:06:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12536 12414 0 66 35 21

2025-05-01 00:07:56 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-01 00:35:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
862 (only retried tests) 763 0 50 29 20

2025-05-01 00:36:02 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-01 01:02:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
710 (only retried tests) 613 0 50 25 22

🟢 2025-05-01 01:02:38 UTC Build successful.
🟢 2025-05-01 01:03:15 UTC ydbd size 3.8 GiB changed* by +25.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1b7b16b merge: 37d5cda diff diff %
ydbd size 4 122 503 408 Bytes 4 122 529 944 Bytes +25.9 KiB +0.001%
ydbd stripped size 1 428 997 080 Bytes 1 429 007 896 Bytes +10.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented May 1, 2025

2025-05-01 05:56:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 39a0025 has started.
2025-05-01 05:57:10 UTC Artifacts will be uploaded here
2025-05-01 06:03:00 UTC ya make is running...
🟡 2025-05-01 07:03:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20105 18741 0 5 1326 33

2025-05-01 07:05:32 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-01 07:29:08 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
353 (only retried tests) 322 0 0 0 31

🟢 2025-05-01 07:29:20 UTC Build successful.
🟢 2025-05-01 07:29:39 UTC ydbd size 2.2 GiB changed* by +1.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1b7b16b merge: 39a0025 diff diff %
ydbd size 2 343 417 512 Bytes 2 343 418 600 Bytes +1.1 KiB +0.000%
ydbd stripped size 492 746 368 Bytes 492 746 816 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented May 1, 2025

2025-05-01 05:57:22 UTC Pre-commit check linux-x86_64-release-asan for 39a0025 has started.
2025-05-01 05:57:33 UTC Artifacts will be uploaded here
2025-05-01 06:02:27 UTC ya make is running...
🟡 2025-05-01 07:34:52 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12536 12384 0 87 43 22

2025-05-01 07:35:53 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-01 08:02:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1016 (only retried tests) 906 0 53 36 21

2025-05-01 08:02:15 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-01 08:29:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
776 (only retried tests) 690 0 50 15 21

🟢 2025-05-01 08:30:00 UTC Build successful.
🟢 2025-05-01 08:30:32 UTC ydbd size 3.8 GiB changed* by +1.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1b7b16b merge: 39a0025 diff diff %
ydbd size 4 122 503 408 Bytes 4 122 504 496 Bytes +1.1 KiB +0.000%
ydbd stripped size 1 428 997 080 Bytes 1 428 997 528 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions github-actions bot added ui and removed ui labels May 1, 2025
Copy link

github-actions bot commented May 5, 2025

2025-05-05 13:24:05 UTC Pre-commit check linux-x86_64-release-asan for 0da256b has started.
2025-05-05 13:24:29 UTC Artifacts will be uploaded here
2025-05-05 13:27:19 UTC ya make is running...
2025-05-05 14:34:30 UTC Check cancelled

@StekPerepolnen StekPerepolnen requested a review from adameat May 5, 2025 13:26
@github-actions github-actions bot added ui and removed ui labels May 5, 2025
@StekPerepolnen StekPerepolnen changed the title viewer: don't use auth for whoami handler viewer: change auth for whoami and viewer/v2 handlers May 5, 2025
@github-actions github-actions bot added ui and removed ui labels May 5, 2025
Copy link

github-actions bot commented May 5, 2025

2025-05-05 13:26:59 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0da256b has started.
2025-05-05 13:27:25 UTC Artifacts will be uploaded here
2025-05-05 13:30:47 UTC ya make is running...

Copy link

github-actions bot commented May 5, 2025

2025-05-05 14:45:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7802911 has started.
2025-05-05 14:45:44 UTC Artifacts will be uploaded here
2025-05-05 14:48:29 UTC ya make is running...
🟡 2025-05-05 15:54:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20109 18740 0 7 1323 39

2025-05-05 15:56:22 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-05 16:11:23 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
597 (only retried tests) 567 0 0 0 30

🟢 2025-05-05 16:11:34 UTC Build successful.
🟢 2025-05-05 16:11:56 UTC ydbd size 2.2 GiB changed* by +1.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6417491 merge: 7802911 diff diff %
ydbd size 2 343 360 048 Bytes 2 343 361 648 Bytes +1.6 KiB +0.000%
ydbd stripped size 493 066 240 Bytes 493 066 880 Bytes +640 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented May 5, 2025

2025-05-05 14:45:57 UTC Pre-commit check linux-x86_64-release-asan for 7802911 has started.
2025-05-05 14:46:08 UTC Artifacts will be uploaded here
2025-05-05 14:48:56 UTC ya make is running...
🟡 2025-05-05 16:10:50 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12538 12365 0 100 46 27

2025-05-05 16:11:55 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-05 16:40:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1003 (only retried tests) 899 0 45 33 26

2025-05-05 16:41:00 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-05 17:05:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
795 (only retried tests) 704 0 44 20 27

🟢 2025-05-05 17:05:25 UTC Build successful.
🟢 2025-05-05 17:05:57 UTC ydbd size 3.8 GiB changed* by +1.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 6417491 merge: 7802911 diff diff %
ydbd size 4 126 493 056 Bytes 4 126 494 896 Bytes +1.8 KiB +0.000%
ydbd stripped size 1 433 271 000 Bytes 1 433 271 832 Bytes +832 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@StekPerepolnen StekPerepolnen changed the title viewer: change auth for whoami and viewer/v2 handlers viewer: change auth for whoami and capabilities handlers May 5, 2025
@github-actions github-actions bot added ui and removed ui labels May 5, 2025
@StekPerepolnen StekPerepolnen merged commit 25bf032 into main May 5, 2025
17 of 18 checks passed
@StekPerepolnen StekPerepolnen deleted the whoami-auth2 branch May 5, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants