Skip to content

Prefix vector impl table has its own settings #18132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

Prefix vector impl table has its own settings #18132

merged 1 commit into from
May 7, 2025

Conversation

azevaykin
Copy link
Collaborator

Changelog entry

Fixed forgotten field GlobalIndexSettings prefix_table_settings = 4; in ydb_table.proto

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@azevaykin azevaykin requested review from a team as code owners May 7, 2025 12:56
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2025

🟢 2025-05-07 13:00:15 UTC The validation of the Pull Request description is successful.

@azevaykin azevaykin linked an issue May 7, 2025 that may be closed by this pull request
Prefix index has 3 tables #17980
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2025 •
edited
Loading

⚪ 2025-05-07 13:08:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for fe0ab05 has started.
⚪ 2025-05-07 13:08:36 UTC Artifacts will be uploaded here
⚪ 2025-05-07 13:12:00 UTC ya make is running...
🟡 2025-05-07 15:26:18 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30331 27655 0 4 2631 41

⚪ 2025-05-07 15:28:46 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-07 16:07:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
672 (only retried tests) 635 0 1 2 34

⚪ 2025-05-07 16:08:06 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-05-07 16:32:13 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
130 (only retried tests) 100 0 0 0 30

🟢 2025-05-07 16:32:24 UTC Build successful.
🔴 2025-05-07 16:32:45 UTC ydbd size 2.2 GiB changed* by +2.3 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 6dde11e merge: fe0ab05 diff diff %
ydbd size 2 343 837 968 Bytes 2 346 272 096 Bytes +2.3 MiB +0.104%
ydbd stripped size 493 065 344 Bytes 493 370 864 Bytes +298.4 KiB +0.062%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2025 •
edited
Loading

⚪ 2025-05-07 13:08:29 UTC Pre-commit check linux-x86_64-release-asan for fe0ab05 has started.
⚪ 2025-05-07 13:08:40 UTC Artifacts will be uploaded here
⚪ 2025-05-07 13:11:59 UTC ya make is running...
🟡 2025-05-07 15:21:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15312 15157 0 84 43 28

⚪ 2025-05-07 15:23:01 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-07 15:56:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1429 (only retried tests) 1310 0 59 31 29

⚪ 2025-05-07 15:56:20 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-07 16:27:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1184 (only retried tests) 1070 0 61 26 27

🟢 2025-05-07 16:27:33 UTC Build successful.
🟢 2025-05-07 16:28:05 UTC ydbd size 3.8 GiB changed* by -52.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 7fd0265 merge: fe0ab05 diff diff %
ydbd size 4 126 396 888 Bytes 4 126 342 752 Bytes -52.9 KiB -0.001%
ydbd stripped size 1 432 968 792 Bytes 1 432 724 032 Bytes -239.0 KiB -0.017%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@azevaykin azevaykin enabled auto-merge (squash) May 7, 2025 13:13
CyberROFL
CyberROFL reviewed May 7, 2025
View reviewed changes
ydb/core/ydb_convert/table_settings.cpp
@@ -461,15 +461,21 @@ bool FillIndexTablePartitioning(
}
break;

case Ydb::Table::TableIndex::kGlobalVectorKmeansTreeIndex:
case Ydb::Table::TableIndex::kGlobalVectorKmeansTreeIndex: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
case Ydb::Table::TableIndex::kGlobalVectorKmeansTreeIndex: {
case Ydb::Table::TableIndex::kGlobalVectorKmeansTreeIndex:

ydb/core/ydb_convert/table_settings.cpp
break;

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}

ydb/core/ydb_convert/table_settings.cpp
Comment on lines +471 to +476
const bool prefixVectorIndex = index.index_columns().size() > 1;
if (prefixVectorIndex) {
if (!fillIndexPartitioning(index.global_vector_kmeans_tree_index().prefix_table_settings(), indexImplTableDescriptions)) {
return false;
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const bool prefixVectorIndex = index.index_columns().size() > 1;
if (prefixVectorIndex) {
if (!fillIndexPartitioning(index.global_vector_kmeans_tree_index().prefix_table_settings(), indexImplTableDescriptions)) {
return false;
}
}
if (index.index_columns().size() > 1) { // prefix vector index
if (!fillIndexPartitioning(index.global_vector_kmeans_tree_index().prefix_table_settings(), indexImplTableDescriptions)) {
return false;
}
}

ydb/core/ydb_convert/table_description.cpp
@@ -1055,7 +1055,7 @@ void FillIndexDescriptionImpl(TYdbProto& out, const NKikimrSchemeOp::TTableDescr
tableIndex.GetIndexImplTableDescriptions(0)
);
break;
case NKikimrSchemeOp::EIndexType::EIndexTypeGlobalVectorKmeansTree:
case NKikimrSchemeOp::EIndexType::EIndexTypeGlobalVectorKmeansTree: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
case NKikimrSchemeOp::EIndexType::EIndexTypeGlobalVectorKmeansTree: {
case NKikimrSchemeOp::EIndexType::EIndexTypeGlobalVectorKmeansTree:

ydb/core/ydb_convert/table_description.cpp

*index->mutable_global_vector_kmeans_tree_index()->mutable_vector_settings() = tableIndex.GetVectorIndexKmeansTreeDescription().GetSettings();

break;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}

ydb/core/ydb_convert/table_description.cpp
Comment on lines +1067 to +1073
const bool prefixVectorIndex = tableIndex.GetKeyColumnNames().size() > 1;
if (prefixVectorIndex) {
FillGlobalIndexSettings(
*index->mutable_global_vector_kmeans_tree_index()->mutable_prefix_table_settings(),
tableIndex.GetIndexImplTableDescriptions(2)
);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const bool prefixVectorIndex = tableIndex.GetKeyColumnNames().size() > 1;
if (prefixVectorIndex) {
FillGlobalIndexSettings(
*index->mutable_global_vector_kmeans_tree_index()->mutable_prefix_table_settings(),
tableIndex.GetIndexImplTableDescriptions(2)
);
}
if (tableIndex.GetKeyColumnNames().size() > 1) { // prefixVectorIndex
FillGlobalIndexSettings(
*index->mutable_global_vector_kmeans_tree_index()->mutable_prefix_table_settings(),
tableIndex.GetIndexImplTableDescriptions(2)
);
}

@azevaykin azevaykin disabled auto-merge May 7, 2025 14:45
@azevaykin azevaykin merged commit 9047047 into ydb-platform:main May 7, 2025
15 checks passed
@azevaykin azevaykin deleted the VectorPrefix3Table branch May 7, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberROFL CyberROFL CyberROFL left review comments

@ijon ijon ijon approved these changes

@pnv1 pnv1 pnv1 approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefix index has 3 tables
4 participants
@azevaykin @ijon @CyberROFL @pnv1