PQ tablet add metadata in offset commit #18133
Open
+106
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 25, 2025 14:40
rename TConsumerOffset struct add PartitionIndex field to TConsumerOffset struct to substitude std::pair in OffsetCommit function
…leSetClientOffsetRequest
add CommittedMetadata as a field in pqconfig.proto to message TUserInfo
add correct typing (const TString&)
nerhneiro
requested review from
nshestakov and
a-serebryanskiy
and removed request for
nshestakov
|
🔴 Unable to merge your PR into the base branch. Please rebase or merge it with the base branch. |
|
🟢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog entry
Add CommittedMetadata field in userInfo to make it possible to send metadata with offset.
Changelog category
Description for reviewers
...