Skip to content

Do not call TaskRunner for periodic stats updates #18143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

Hor911
Copy link
Collaborator

@Hor911 Hor911 commented May 8, 2025

Periodic stats updates were based on TaskRunner timings and include TaskRunner Run() call for updates, so caused extra (unwanted) program runs.

The PR removes this call and makes periodic stats less intrusive

@Hor911 Hor911 requested review from a team as code owners May 8, 2025 09:59
Copy link

github-actions bot commented May 8, 2025

🟢 2025-05-08 10:02:24 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented May 8, 2025

2025-05-08 10:03:00 UTC Pre-commit check linux-x86_64-release-asan for cb7c414 has started.
2025-05-08 10:03:11 UTC Artifacts will be uploaded here
2025-05-08 10:06:00 UTC ya make is running...
🟡 2025-05-08 11:33:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13040 12852 0 130 30 28

2025-05-08 11:34:54 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-08 12:10:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1636 (only retried tests) 1490 0 74 48 24

2025-05-08 12:11:03 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-08 12:43:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1238 (only retried tests) 1128 0 53 33 24

🟢 2025-05-08 12:43:17 UTC Build successful.
🟢 2025-05-08 12:43:48 UTC ydbd size 3.8 GiB changed* by -1.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: e4d3ee7 merge: cb7c414 diff diff %
ydbd size 4 126 362 640 Bytes 4 126 361 312 Bytes -1.3 KiB -0.000%
ydbd stripped size 1 432 730 464 Bytes 1 432 729 824 Bytes -640 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented May 8, 2025

2025-05-08 10:03:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for cb7c414 has started.
2025-05-08 10:03:21 UTC Artifacts will be uploaded here
2025-05-08 10:06:09 UTC ya make is running...
🟡 2025-05-08 11:20:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28016 25329 0 4 2642 41

2025-05-08 11:22:36 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-08 11:45:56 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
167 (only retried tests) 129 0 0 8 30

🟢 2025-05-08 11:46:02 UTC Build successful.
🟢 2025-05-08 11:46:22 UTC ydbd size 2.2 GiB changed* by -304 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: e4d3ee7 merge: cb7c414 diff diff %
ydbd size 2 346 283 080 Bytes 2 346 282 776 Bytes -304 Bytes -0.000%
ydbd stripped size 493 372 816 Bytes 493 372 752 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Hor911 Hor911 merged commit 4c573ce into ydb-platform:main May 8, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants