Skip to content

Ydb bug fix session timeout leave group stable 25 1 #19785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: stable-25-1
Choose a base branch
from

Conversation

nerhneiro
Copy link
Collaborator

Changelog entry

Issue: #19784

Fix bug with too long session timeout

Changelog category

  • Bugfix

Description for reviewers

...

Irina Skvortsova added 3 commits June 18, 2025 07:23
change heartbeat_deadline from now + rebalaceTimeout + sessionTimeout to just now + sessionTimeout
add checks to stop waiting ungracefully finished consumers after sessionTimeout has passed
@nerhneiro nerhneiro requested a review from a team as a code owner June 18, 2025 07:36
Copy link

github-actions bot commented Jun 18, 2025

2025-06-18 07:37:24 UTC Pre-commit check linux-x86_64-release-asan for f784b75 has started.
2025-06-18 07:37:35 UTC Artifacts will be uploaded here
2025-06-18 07:40:23 UTC ya make is running...
🟡 2025-06-18 08:51:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12029 11896 0 34 65 34

2025-06-18 08:52:28 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-18 09:12:34 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
165 (only retried tests) 78 0 7 47 33

2025-06-18 09:12:43 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-18 09:33:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
115 (only retried tests) 35 0 7 40 33

🟢 2025-06-18 09:33:15 UTC Build successful.
🟢 2025-06-18 09:33:45 UTC ydbd size 3.7 GiB changed* by +23.7 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 73ed6e3 merge: f784b75 diff diff %
ydbd size 3 928 335 264 Bytes 3 928 359 520 Bytes +23.7 KiB +0.001%
ydbd stripped size 1 373 705 248 Bytes 1 373 718 752 Bytes +13.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

🟢 2025-06-18 07:39:05 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Jun 18, 2025

2025-06-18 07:39:19 UTC Pre-commit check linux-x86_64-relwithdebinfo for f784b75 has started.
2025-06-18 07:39:30 UTC Artifacts will be uploaded here
2025-06-18 07:42:17 UTC ya make is running...
🟡 2025-06-18 08:39:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18884 17595 0 6 1221 62

2025-06-18 08:41:03 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-18 09:01:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
151 (only retried tests) 92 0 0 1 58

🟢 2025-06-18 09:01:56 UTC Build successful.
🟢 2025-06-18 09:02:14 UTC ydbd size 2.1 GiB changed* by +15.6 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 73ed6e3 merge: f784b75 diff diff %
ydbd size 2 258 258 720 Bytes 2 258 274 720 Bytes +15.6 KiB +0.001%
ydbd stripped size 478 032 504 Bytes 478 040 248 Bytes +7.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant