YQ fixed kqprun grpc endpoints #19790
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements per-node kqprun GRpc endpoints by updating tenant creation and GRpc initialization logic.
- In ydb_setup.cpp, the GRpc port parameter has been removed from CreateTenant and tenant/server initialization logic has been adjusted.
- In test_client.h and test_client.cpp, the GRpc structures have been updated to support a per-node mapping for GRpc endpoints.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ydb/tests/tools/kqprun/src/ydb_setup.cpp | Removed the grpcPort parameter and shifted GRpc endpoint enabling logic from CreateTenant into tenant initialization methods. |
| ydb/core/testlib/test_client.h | Changed the TenantsGRpc mapping to use a nested unordered_map keyed by tenant then node index. |
| ydb/core/testlib/test_client.cpp | Modified GRpc enabling and lookup logic to utilize per-node GRpc info. |
|
🟢 |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ Test history | Ya make output | Test bloat
⚪ Test history | Ya make output | Test bloat | Test bloat
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| // Port for first static node also used in cluster initialization | ||
| Server_->EnableGRpc(grpcPortGen.GetPort(), node, absolutePath); | ||
| } | ||
| } else if (Settings_.MonitoringEnabled) { |
There was a problem hiding this comment.
А тут точно должен быть else if, а не if? (так было и в оригинальном коде выше, если это ошибка -- то не новая, но чуть странно)
Changelog entry
Added per node kqprun grpc endpoints in kqprun
Changelog category
Description for reviewers