Speedup bulkupsert (#17333)

[eivanov89]

Changelog entry

...

Changelog category

• Not for changelog (changelog entry is not required)

Description for reviewers

...

[Copilot]

Pull Request Overview

This PR aims to speed up the bulk upsert operation by replacing the assignment of proto messages with swap operations to avoid unnecessary copying.

• Replaces the assignment of proto types and values with Swap in the bulk upsert requests.
• Applies the change in two files to improve runtime efficiency.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
ydb/public/sdk/cpp/src/client/table/impl/table_client.cpp	Uses Swap for proto types and values in bulk upsert request
ydb/public/sdk/cpp/client/ydb_table/impl/table_client.cpp	Uses Swap for proto types and values in bulk upsert request

Comments suppressed due to low confidence (2)

ydb/public/sdk/cpp/src/client/table/impl/table_client.cpp:995

• Swapping the proto data avoids copying, which improves performance. Please confirm that the rows object being modified by Swap is acceptable and consider adding a comment to document this intentional side-effect.

    request.mutable_rows()->mutable_type()->Swap(&rows.GetType().GetProto());

ydb/public/sdk/cpp/client/ydb_table/impl/table_client.cpp:940

• Using Swap improves efficiency by eliminating a copy, but ensure that modifying rows through Swap is intended. Adding an inline comment to clarify the swap semantics would help maintainability.

    request.mutable_rows()->mutable_type()->Swap(&rows.GetType().GetProto());

[github-actions]

🟢 2025-06-18 08:56:41 UTC The validation of the Pull Request description is successful.

[github-actions]

⚪ 2025-06-18 08:59:10 UTC Pre-commit check linux-x86_64-release-asan for e38baa4 has started.
⚪ 2025-06-18 08:59:23 UTC Artifacts will be uploaded here
⚪ 2025-06-18 09:02:44 UTC ya make is running...
⚫ 2025-06-18 10:05:16 UTC Check cancelled

[github-actions]

⚪ 2025-06-18 09:03:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for e38baa4 has started.
⚪ 2025-06-18 09:03:51 UTC Artifacts will be uploaded here
⚪ 2025-06-18 09:07:31 UTC ya make is running...
⚫ 2025-06-18 10:05:14 UTC Check cancelled

[github-actions]

⚪ 2025-06-18 10:09:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for a6af9b6 has started.
⚪ 2025-06-18 10:10:40 UTC Artifacts will be uploaded here
⚪ 2025-06-18 10:15:05 UTC ya make is running...
🟡 2025-06-18 12:08:10 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
38290	35562	0	2	2676	50

⚪ 2025-06-18 12:11:50 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-06-18 12:24:54 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
513 (only retried tests)	483	0	0	4	26

🟢 2025-06-18 12:25:05 UTC Build successful.
🟡 2025-06-18 12:25:27 UTC ydbd size 2.2 GiB changed* by +166.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: abeada2	merge: a6af9b6	diff	diff %
ydbd size	2 373 000 616 Bytes	2 373 171 552 Bytes	+166.9 KiB	+0.007%
ydbd stripped size	497 531 720 Bytes	497 551 752 Bytes	+19.6 KiB	+0.004%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

[github-actions]

⚪ 2025-06-18 10:32:47 UTC Pre-commit check linux-x86_64-release-asan for a6af9b6 has started.
⚪ 2025-06-18 10:32:59 UTC Artifacts will be uploaded here
⚪ 2025-06-18 10:36:47 UTC ya make is running...
🟡 2025-06-18 13:01:44 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
16058	15664	0	211	153	30

⚪ 2025-06-18 13:03:11 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-06-18 13:40:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
2370 (only retried tests)	2168	0	65	109	28

⚪ 2025-06-18 13:41:29 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-06-18 14:17:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED?
1807 (only retried tests)	1611	0	66	105	25

🟢 2025-06-18 14:17:45 UTC Build successful.
🟢 2025-06-18 14:18:22 UTC ydbd size 3.9 GiB changed* by +3.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: 0ee880e	merge: a6af9b6	diff	diff %
ydbd size	4 174 045 320 Bytes	4 174 049 000 Bytes	+3.6 KiB	+0.000%
ydbd stripped size	1 447 369 528 Bytes	1 447 370 488 Bytes	+960 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}