fix(code quality): Improve error for S3 upload in Batcher (#1014)

yetanotherco · Sep 24, 2024 · 9358698 · 9358698
1 parent bc6f49d
commit 9358698
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/batcher/aligned-batcher/src/lib.rs b/batcher/aligned-batcher/src/lib.rs
@@ -1018,7 +1018,7 @@ impl Batcher {
             &file_name,
         )
         .await
-        .map_err(|e| BatcherError::TaskCreationError(e.to_string()))?;
+        .map_err(|e| BatcherError::BatchUploadError(e.to_string()))?;
 
         info!("Batch sent to S3 with name: {}", file_name);
 

diff --git a/batcher/aligned-batcher/src/types/errors.rs b/batcher/aligned-batcher/src/types/errors.rs
@@ -9,6 +9,7 @@ pub enum BatcherError {
     BatchVerifiedEventStreamError(String),
     EthereumSubscriptionError(String),
     SignatureError(SignatureError),
+    BatchUploadError(String),
     TaskCreationError(String),
     ReceiptNotFoundError,
     TransactionSendError,
@@ -49,6 +50,9 @@ impl fmt::Debug for BatcherError {
             BatcherError::SignatureError(e) => {
                 write!(f, "Message signature verification error: {}", e)
             }
+            BatcherError::BatchUploadError(e) => {
+                write!(f, "Uploading Batch was not successful: {}", e)
+            }
             BatcherError::TaskCreationError(e) => {
                 write!(f, "Task creation error: {}", e)
             }