Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(code quality): Improve error for S3 upload in Batcher #1014

Merged
merged 2 commits into from
Sep 24, 2024
Merged

fix(code quality): Improve error for S3 upload in Batcher #1014

merged 2 commits into from
Sep 24, 2024

Conversation

PatStiles
Copy link
Contributor

@PatStiles PatStiles commented Sep 19, 2024 •
edited by uri-99
Loading

Improves the error for uploading batches to S3 in the batcher.

closes #1011

@PatStiles PatStiles changed the base branch from testnet to staging September 19, 2024 13:33
MauroToscano
MauroToscano requested changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@MauroToscano MauroToscano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this error get printed ? Also, maybe change S3BatchUploadError to BatchUploadError, since we are not using S3

@PatStiles PatStiles self-assigned this Sep 19, 2024
@entropidelic entropidelic merged commit 9358698 into staging Sep 24, 2024
1 check passed
@entropidelic entropidelic deleted the 1011-improve-error-when-uploading-to-bucket branch September 24, 2024 20:35
This was referenced Sep 30, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

@uri-99 uri-99 uri-99 approved these changes

Assignees

@PatStiles PatStiles

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PatStiles @MauroToscano @uri-99 @entropidelic