feat(vk): commit proof_commitment with vk and proof system to verify a vk corresponds to a proof. #1083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1042
Hashes the
proof
with theverification_key/vm_program_code
+proving_system_byte
. Specificallyproof_commitment
is added to the hashing of theproving_system_aux_data_commitment
. This binds the proof, verification_key, and proving_system (via id) into one commitment that can be verified via a merkle root check.This ensures the
verification_key
is binding with respect to the proof.TODO:
get_vk_commitment
and verifying information on chain works