Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vk): commit proof_commitment with vk and proof system to verify a vk corresponds to a proof. #1083

Conversation

PatStiles
Copy link
Contributor

@PatStiles PatStiles commented Sep 25, 2024

closes: #1042

Hashes the proof with the verification_key/vm_program_code + proving_system_byte. Specifically proof_commitment is added to the hashing of the proving_system_aux_data_commitment. This binds the proof, verification_key, and proving_system (via id) into one commitment that can be verified via a merkle root check.

This ensures the verification_key is binding with respect to the proof.

TODO:

  • Test on local testnet.
  • Verify get_vk_commitment and verifying information on chain works
  • Verify proofs with a different verification key than the commitment cannot be verified.

@PatStiles PatStiles marked this pull request as draft September 25, 2024 15:07
@PatStiles PatStiles self-assigned this Sep 25, 2024
@PatStiles PatStiles closed this Sep 30, 2024
@MauroToscano MauroToscano deleted the 1042-verify-vk-corresponds-to-proof-in-verification-data branch January 2, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant