Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rm halo2 from verifiers #1128

Merged
merged 3 commits into from
Oct 3, 2024
Merged

chore: rm halo2 from verifiers #1128

merged 3 commits into from
Oct 3, 2024

Conversation

PatStiles
Copy link
Contributor

Removes halo2 verifiers from aligned.

closes #1117 .

To Test:

  • Run a local testnet and verify that everything works.

@PatStiles PatStiles changed the title chore(rm halo2 from memory... forever chore: rm halo2 from verifiers Sep 30, 2024
@PatStiles PatStiles self-assigned this Sep 30, 2024
Copy link
Collaborator

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested on my machine!

@uri-99
Copy link
Contributor

uri-99 commented Oct 3, 2024

why are there still instances of halo2 in the cargo.locks? I can't seem to be able to remove them properly

@uri-99 uri-99 merged commit 8a6340f into staging Oct 3, 2024
5 checks passed
@uri-99 uri-99 deleted the 1117-remove-halo2-bindings branch October 3, 2024 20:55
PatStiles added a commit that referenced this pull request Oct 7, 2024
Co-authored-by: Urix <43704209+uri-99@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants