Set opt optimization level to 2 #1355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oppen
reviewed
Nov 4, 2024
docker/aligned_base.Dockerfile
Outdated
| @@ -41,6 +41,8 @@ FROM lukemathwalker/cargo-chef:latest-rust-1 AS chef | |||
|
|
|||
| FROM chef AS planner | |||
|
|
|||
| ENV RUSTFLAGS="-C codegen-units=256 -C incremental=true -C opt-level=0" | |||
There was a problem hiding this comment.
Remove the incremental flag. It doesn't really help in CI environments and generates a lot of data for the cache.
There was a problem hiding this comment.
Also, you might want to use lto=false.
There was a problem hiding this comment.
It is caching the files though
There was a problem hiding this comment.
Also lto = false is the default of release
There was a problem hiding this comment.
I removed the incremental, cargo chef mentions it's redudant and increases the amount of layers in docker file. lto false seems to not change anything since the default is release.
MauroToscano
requested changes
Nov 5, 2024
MauroToscano
changed the title
MauroToscano
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TITLE
Description
Description of the pull request changes and motivation.
Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging