Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove required=true from privatekeytype in CLI #1767

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix: remove required=true from privatekeytype in CLI #1767

merged 1 commit into from
Jan 22, 2025

Conversation

uri-99
Copy link
Contributor

@uri-99 uri-99 commented Jan 20, 2025

remove required=true from PrivateKeyType

Description

PrivateKeyType should be able to be empty, so we can handle the "using nonpaying address" for testnet proof submitions

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@uri-99 uri-99 linked an issue Jan 20, 2025 that may be closed by this pull request
fix: remove required=true from PrivateKeyType #1766
Closed
@uri-99 uri-99 self-assigned this Jan 20, 2025
@uri-99 uri-99 changed the base branch from testnet to staging January 20, 2025 20:35
@uri-99 uri-99 added this pull request to the merge queue Jan 22, 2025
Merged via the queue into staging with commit 054d1dd Jan 22, 2025
7 checks passed
@uri-99 uri-99 deleted the 1766-fix-remove-requiredtrue-from-privatekeytype branch January 22, 2025 19:36
@JuArce JuArce mentioned this pull request Feb 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oppen Oppen Oppen approved these changes

@JuArce JuArce JuArce approved these changes

Assignees

@uri-99 uri-99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: remove required=true from PrivateKeyType
3 participants
@uri-99 @Oppen @JuArce