Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explorer): show correct cost per proof and remove inspects #830

Merged
merged 287 commits into from
Aug 27, 2024

Conversation

glpecile
Copy link
Contributor

@glpecile glpecile commented Aug 21, 2024

Important

We should test in stage first and compare results.
This also needs a redeploy of the contracts.
This PR could have conflicts w/ #843.

Changes

Test

  • Start aligned locally
  • Run explorer and verify everything works, prices should now be higher than the deployed version

glpecile and others added 30 commits July 15, 2024 15:54
…at-show-proof-hashes-in-each-batch' of https://github.com/yetanotherco/aligned_layer into 605-feat-show-proof-hashes-in-each-batch
Co-authored-by: Gian <58370608+glpecile@users.noreply.github.com>
@glpecile glpecile changed the title fix(explorer): show correct cost per proof fix(explorer): show correct cost per proof and remove inspects Aug 23, 2024
@glpecile glpecile requested a review from uri-99 August 23, 2024 23:36
@glpecile glpecile added the frontend Frontend related issue. label Aug 23, 2024
…t-per-proof

# Conflicts:
#	contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json
#	contracts/src/core/BatcherPaymentService.sol
Copy link

github-actions bot commented Aug 27, 2024

Changes to gas cost

Generated at commit: 8a7578659fb3741cb85d29bf1796f17bf4be8d65, compared to commit: 288db9e6c1b2f239411a2efa025551e96866097f

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager createNewTask -4 ✅ -0.01%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 4,359,036 (0) createNewTask 51,138 (0) 0.00% 51,323 (-4) -0.01% 51,240 (+6) +0.01% 51,876 (+24) +0.05% 256 (0)

@glpecile glpecile merged commit 61624d9 into main Aug 27, 2024
3 checks passed
@glpecile glpecile deleted the explorer/742-fix-show-correct-cost-per-proof branch August 27, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Frontend related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore(explorer): replace inspect for logger fix(explorer): show correct cost per proof
3 participants