-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: batcher nonce verification order in handle_message function #864
fix: batcher nonce verification order in handle_message function #864
Conversation
…message functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User can submit a transaction with the same nonce while the proofs are verifying and this could end up in an invalid state. The nonce needs to be blocked while this process is going.
Solved in aff5aac |
it seems like when a createNewTask transaction is reverted, the nonce is set to an invalid state and then all proofs sent with that address get an
when the transaction is reverted because of the repeated merkle root, you should not be able to send any more proofs with that address |
Solved in ea00344. I added a condition that thought was necessary but it didn't make sense |
…handle_message-function # Conflicts: # batcher/aligned-batcher/src/lib.rs
Co-authored-by: Tatu <65305492+taturosati@users.noreply.github.com>
…in-handle_message-function # Conflicts: # batcher/aligned-batcher/src/lib.rs
Being solved in #1087 and 'refactor-user-states' |
Closes #1081
Description
handle_message
andhandle_nonpaying_msg
.To Test