Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 'V2' functionalities to aggregator and operator #875

Merged
merged 48 commits into from
Sep 5, 2024
Merged

refactor: 'V2' functionalities to aggregator and operator #875

merged 48 commits into from
Sep 5, 2024

Conversation

uri-99
Copy link
Contributor

@uri-99 uri-99 commented Aug 27, 2024 •
edited
Loading

Note

This contracts upgrade must be done AFTER: 4th of September

This branch has been merged into #851 , and both deployed to STAGE (contract and operator)
For smoother merge conflicts, this PR should be merged before #883

uri-99 added 26 commits August 26, 2024 15:59
@uri-99
fix: add again old NewBatch event
eadece7
@uri-99
chore: make bindings and redeploy contracts
f27fd9a
@uri-99
fix: go bindings
e015126
@uri-99
feat: add RespondToTaskOld
d1a325f
@uri-99
refactor: change _old for old, to V2 for new
3ca02bc
@uri-99
feat: add sendAggregatedResponseV2 to aggregator
ca7fd53
@uri-99
feat: add processNewBatchV2 to avs_subscriber
679ed22
@uri-99
feat: add SignedTaskResponseV2
feab74c
@uri-99
feat: add ProcessNewBatchLogV2
9fe3900
@uri-99
feat: subscribeToNewTasksV2, SubscribeToNewTasksV2, getLatestTaskFrom…
019f7cc 
…EthereumV2
@uri-99
feat: aggregator: sendAggregatedResponseV2, AddNewTaskV2
60b1ccd
@uri-99
feat: subscriber SubscribeToNewTasksV2
0038673
@uri-99
feat: server ProcessOperatorSignedTaskResponseV2
e1088d3
@uri-99
feat: operator NewTaskCreatedChanV2, and discerning ProcessNewBatchLogV2
318ef36
@uri-99
feat: rpc_client SendSignedTaskResponseToAggregatorV2
48d7cc8
@uri-99
feat: aggregator v1 v2 discerning
99b503f
@uri-99
fixes: fix
5a5f4f8
@uri-99
remove: agg subscribe to v2 in different goroutine, now subscribes bo…
6fa127a 
…th together
@uri-99
feat: agg subscribes to both success
549a2ba
@uri-99
feat: add if block.number in alignedservicemanager.sol
943d7a1
@uri-99
feat: reading of blockNumber insteadof B2 bool
79a6a33
@uri-99
feat: if block num in aggregator
642169d
@uri-99
fix: lower block num
87ac992
@uri-99
fix: if conditions and switchBlockNumber
23947ee
@uri-99
refactor: comment on respondToTask easier to use
06e86d6
@uri-99
refactor: add 'V2' to event NewBatch and function respondToTask
905f740
@uri-99 uri-99 linked an issue Aug 27, 2024 that may be closed by this pull request
refactor: rename main contracts to V2 #874
Closed
@uri-99 uri-99 self-assigned this Aug 28, 2024
@uri-99 uri-99 marked this pull request as draft August 28, 2024 18:53
@uri-99 uri-99 mentioned this pull request Aug 28, 2024
Closed
@uri-99 uri-99 changed the title refactor: add 'V2' to event NewBatch and function respondToTask refactor: 'V2' functionalities to aggregator and operator Sep 3, 2024
@uri-99 uri-99 marked this pull request as ready for review September 4, 2024 14:04
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024 •
edited
Loading

Changes to gas cost

Generated at commit: 3b52fcedc09f87e2eea9f5b0b640e78c355440f2, compared to commit: c6d845915a1d568ab1c4c3dfe1441b3b3813a299

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager batchesState -22 ✅ -3.88%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 4,524,203 (+89,223) batchesState 545 (-22) -3.88% 545 (-22) -3.88% 545 (-22) -3.88% 545 (-22) -3.88% 256 (0)

@JuArce JuArce merged commit 81b290d into main Sep 5, 2024
5 checks passed
@JuArce JuArce deleted the 874-refactor-rename-main-contracts-to-v2 branch September 5, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuArce JuArce JuArce approved these changes

@entropidelic entropidelic entropidelic approved these changes

Assignees

@uri-99 uri-99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: rename main contracts to V2
3 participants
@uri-99 @JuArce @entropidelic