Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change less than = 0 in contracts to == 0to reduce gas costs when the number is unsigned #892

Merged
merged 3 commits into from
Aug 29, 2024
Merged

fix: change less than = 0 in contracts to == 0to reduce gas costs when the number is unsigned #892

merged 3 commits into from
Aug 29, 2024

Conversation

NicolasRampoldi
Copy link
Contributor

@NicolasRampoldi NicolasRampoldi commented Aug 29, 2024 •
edited
Loading

Description

  • Changes <= to == in BatcherPaymentService and AlignedLayerServiceManager when it is checked against a uint.

@NicolasRampoldi NicolasRampoldi linked an issue Aug 29, 2024 that may be closed by this pull request
Change less than <= 0 in contracts to == 0to reduce gas costs when the number is unsigned #889
Closed
@NicolasRampoldi NicolasRampoldi self-assigned this Aug 29, 2024
@github-actions GitHub Actions
Copy link

Changes to gas cost

Generated at commit: 49d8534096eb1b009346e753c21611af83c98112, compared to commit: 80cbc1a79f48a0eafe04760f0241e8fdf626f9dd

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager receive -6 ✅ -0.01%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 4,434,980 (-636) receive 45,053 (-6) -0.01% 45,053 (-6) -0.01% 45,053 (-6) -0.01% 45,053 (-6) -0.01% 256 (0)

@MauroToscano MauroToscano merged commit b2982a9 into main Aug 29, 2024
3 checks passed
@MauroToscano MauroToscano deleted the 889-change-less-than-=-0-in-contracts-to-==-0to-reduce-gas-costs-when-the-number-is-unsigned branch August 29, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MauroToscano MauroToscano MauroToscano approved these changes

@uri-99 uri-99 uri-99 approved these changes

@entropidelic entropidelic Awaiting requested review from entropidelic

Assignees

@NicolasRampoldi NicolasRampoldi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change less than <= 0 in contracts to == 0to reduce gas costs when the number is unsigned
4 participants
@NicolasRampoldi @MauroToscano @uri-99 @entropidelic