Update JUnit tests

docs/README.md

@@ -8,6 +8,13 @@ applications.
 
 ![](Ui.png)
 
+## Getting Started
+
+1. Download the `.jar` file from [here](https://github.com/yisiox/ip/releases).
+2. Open a terminal in the directory which you saved the `.jar` file, then run
+   1. `java -jar earl.jar` for GUI mode.
+   2. `java -jar earl.jar nogui` for TUI mode.
+
 ## Quick Reference
 
 | Command    | Arguments                                       |

src/main/java/earl/Earl.java

@@ -29,7 +29,7 @@ public Earl(String filePath) {
         storage = new Storage(filePath);
         tasks = new TaskList(storage.load(TaskStorageParser::parse));
         if (!storage.wasLoadSuccessful()) {
-            ui.makeResponse("Storage hath succumb to corruption... ",
+            ui.buildResponse("Storage hath succumb to corruption... ",
                     "initiating an unfortunate state of emptiness.");
         }
         ui.showGreeting();

src/main/java/earl/gui/Launcher.java

@@ -1,7 +1,6 @@
 package earl.gui;
 
 import earl.Earl;
-
 import javafx.application.Application;
 
 /**
@@ -13,7 +12,7 @@ public static void main(String[] args) {
             Earl earl = new Earl("data/earl.txt");
             earl.run();
             return;
-        };
+        }
         Application.launch(Main.class, args);
     }
 }

src/main/java/earl/logic/EventHandler.java

@@ -1,7 +1,6 @@
 package earl.logic;
 
 import earl.exceptions.EarlException;
-import earl.tasks.Task;
 import earl.tasks.TaskType;
 import earl.util.TaskList;
 import earl.util.Ui;

src/main/java/earl/logic/HandlerType.java

@@ -5,49 +5,49 @@
  */
 public enum HandlerType {
 
-    list {
+    LIST {
         @Override
         public Handler createHandler(String args) {
             return new ListHandler(args);
         }
     },
-    todo {
+    TODO {
         @Override
         public Handler createHandler(String args) {
             return new TodoHandler(args);
         }
     },
-    deadline {
+    DEADLINE {
         @Override
         public Handler createHandler(String args) {
             return new DeadlineHandler(args);
         }
     },
-    event {
+    EVENT {
         @Override
         public Handler createHandler(String args) {
             return new EventHandler(args);
         }
     },
-    mark {
+    MARK {
         @Override
         public Handler createHandler(String args) {
             return new MarkHandler(args);
         }
     },
-    unmark {
+    UNMARK {
         @Override
         public Handler createHandler(String args) {
             return new UnmarkHandler(args);
         }
     },
-    delete {
+    DELETE {
         @Override
         public Handler createHandler(String args) {
             return new DeleteHandler(args);
         }
     },
-    find {
+    FIND {
         @Override
         public Handler createHandler(String args) {
             return new FindHandler(args);

src/main/java/earl/logic/TaskHandler.java

@@ -4,18 +4,12 @@
 import earl.tasks.Task;
 import earl.tasks.TaskType;
 import earl.util.TaskList;
-import earl.util.Ui;
 
 /**
  * Abstract class representing the adding of a task.
  */
 public abstract class TaskHandler extends Handler {
 
-    protected final String[] successMessageFormats = {
-            "A new %s %s",
-            "hath been appended to the roster of responsibilities.",
-            "The ledger of tasks bears witness to %d endeavour(s)."};
-
     /** Class constructor. */
     public TaskHandler(String args) {
         super(args);
@@ -27,16 +21,16 @@ protected String[] addTask(TaskList tasks, TaskType type, String... data)
             Task newTask = type.createTask(data);
             tasks.add(newTask);
 
-            return new String[]{
-                    String.format(successMessageFormats[0],
-                            type.name().toLowerCase(), newTask.toString()),
-                    successMessageFormats[1],
-                    String.format(successMessageFormats[2], tasks.getSize())};
+            String first = "A new " + type.name() + " " + newTask.toString();
+            String second = "hath been appended to the "
+                    + "roster of responsibilities.";
+            String third = "The ledger of tasks bears witness to "
+                    + tasks.getSize() + " endeavour(s).";
+            return new String[]{first, second, third};
         } catch (IndexOutOfBoundsException e) {
             throw new EarlException("An error befalls. Example use:");
         } catch (Exception e) {
-            throw new EarlException("Command hath faltered: "
-                    + "obscure employment of "
+            throw new EarlException("Incomprehensible employment of "
                     + type.name().toLowerCase() + ". Example use:");
         }
     }

src/main/java/earl/util/Ui.java

@@ -88,8 +88,11 @@ public String appendNewline(String line) {
         return line + NEWLINE;
     }
 
+    /** Displays the initial greeting. */
     public void showGreeting() {
-        makeResponse(GREETING_MESSAGE);
+        // response is built in case of any preceding error messages
+        buildResponse(GREETING_MESSAGE);
+        completeResponse();
     }
 
     public void showGoodbye() {

src/main/java/earl/util/parsers/InputParser.java

@@ -21,7 +21,7 @@ public static Handler parse(String input) throws ParserException {
             // all valid input is expected to be of the format
             // <command> [<arg1>, <arg2>, ...]
             String[] data = input.split("\\s", 2);
-            String command = data[0];
+            String command = data[0].toUpperCase();
             String args = (data.length > 1) ? data[1] : "";
             HandlerType handlerType = HandlerType.valueOf(command);
             return handlerType.createHandler(args);

src/test/java/earl/logic/DeleteHandlerTest.java

@@ -27,7 +27,7 @@ void setUp() {
 
     @Test
     void handle_normalInput_success() throws Exception {
-        Handler handler = HandlerType.delete.createHandler("1");
+        Handler handler = HandlerType.DELETE.createHandler("1");
         handler.handle(new TaskListStub(), new UiStub());
         String newLine = System.lineSeparator();
         assertEquals("Item(s) heretofore have been expunged." + newLine
@@ -37,7 +37,7 @@ void handle_normalInput_success() throws Exception {
     @Test
     void handle_nonIntegerInput_exceptionThrown() {
         try {
-            Handler handler = HandlerType.delete.createHandler("a");
+            Handler handler = HandlerType.DELETE.createHandler("a");
             handler.handle(new TaskListStub(), new UiStub());
             fail();
         } catch (Exception e) {

src/test/java/earl/logic/MarkHandlerTest.java

@@ -27,7 +27,7 @@ void setUp() {
 
     @Test
     void handle_normalCommand_success() throws Exception {
-        Handler handler = HandlerType.mark.createHandler("1");
+        Handler handler = HandlerType.MARK.createHandler("1");
         handler.handle(new TaskListStub(), new UiStub());
         String newLine = System.lineSeparator();
         assertEquals("Item(s) duly accomplished." + newLine
@@ -38,7 +38,7 @@ void handle_normalCommand_success() throws Exception {
     @Test
     void handle_nonIntegerInput_exceptionThrown() {
         try {
-            Handler handler = HandlerType.mark.createHandler("a");
+            Handler handler = HandlerType.MARK.createHandler("a");
             handler.handle(new TaskListStub(), new UiStub());
             fail();
         } catch (Exception e) {

src/test/java/earl/logic/TodoHandlerTest.java

@@ -30,9 +30,9 @@ void setUp() {
 
     @Test
     void handle_normalCommand_success() throws Exception {
-        Handler handler = HandlerType.todo.createHandler("test");
+        Handler handler = HandlerType.TODO.createHandler("test");
         handler.handle(new TaskListStub(), new UiStub());
-        String expected = "A new todo [T][ ] test"
+        String expected = "A new TODO [T][ ] test"
                 + NEWLINE
                 + "hath been appended to the roster of responsibilities."
                 + NEWLINE
@@ -44,7 +44,7 @@ void handle_normalCommand_success() throws Exception {
     @Test
     void handle_emptyDescription_exceptionThrown() {
         try {
-            Handler handler = HandlerType.todo.createHandler("");
+            Handler handler = HandlerType.TODO.createHandler("");
             handler.handle(new TaskListStub(), new UiStub());
             fail();
         } catch (EarlException e) {

src/test/java/earl/util/parsers/InputParserTest.java

@@ -23,10 +23,10 @@ void parse_normalInput_handlerReturnedSuccess() throws Exception {
     @Test
     void parse_invalidInput_exceptionThrown() {
         try {
-            InputParser.parse("TODO ip");
+            InputParser.parse("no ip");
             fail();
         } catch (ParserException e) {
-            assertEquals("TODO ip", e.getMessage());
+            assertEquals("no ip", e.getMessage());
         }
     }
 }

text-ui-test/EXPECTED.TXT

@@ -3,16 +3,16 @@
     Pray, how may I be of service to you on this auspicious day?
     ____________________________________________________________
     ____________________________________________________________
-    A new todo [T][ ] wash dishes, by virtue of your decree,
+    A new TODO [T][ ] wash dishes
     hath been appended to the roster of responsibilities.
     The ledger of tasks bears witness to 1 endeavour(s).
     ____________________________________________________________
     ____________________________________________________________
-    Command hath faltered: obscure employment of deadline. Example use:
+    Incomprehensible employment of deadline. Example use:
     deadline <task name> /by <date time>
     ____________________________________________________________
     ____________________________________________________________
-    Command hath faltered: obscure employment of event. Example use:
+    Incomprehensible employment of event. Example use:
     deadline <task name> /from <date time> /to <date time>
     ____________________________________________________________
     ____________________________________________________________
@@ -33,17 +33,17 @@
     An error proclaims the absence of valid indices in range.
     ____________________________________________________________
     ____________________________________________________________
-    A new todo [T][ ] a, by virtue of your decree,
+    A new TODO [T][ ] a
     hath been appended to the roster of responsibilities.
     The ledger of tasks bears witness to 2 endeavour(s).
     ____________________________________________________________
     ____________________________________________________________
-    A new todo [T][ ] b, by virtue of your decree,
+    A new TODO [T][ ] b
     hath been appended to the roster of responsibilities.
     The ledger of tasks bears witness to 3 endeavour(s).
     ____________________________________________________________
     ____________________________________________________________
-    A new todo [T][ ] c, by virtue of your decree,
+    A new TODO [T][ ] c
     hath been appended to the roster of responsibilities.
     The ledger of tasks bears witness to 4 endeavour(s).
     ____________________________________________________________