Improve readability of mass operations

yisiox · Feb 18, 2024 · db5efaf · db5efaf
1 parent d976292
commit db5efaf
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 9 deletions.
diff --git a/src/main/java/earl/logic/DeleteHandler.java b/src/main/java/earl/logic/DeleteHandler.java
@@ -24,11 +24,13 @@ public void handle(TaskList tasks, Ui ui) throws EarlException {
                         + "valid indices in range.");
                 return;
             }
+
             for (int idx : indices) {
                 addDisplayEntry(idx + 1 + "." + tasks.delete(idx));
             }
             addDisplayEntry("Item(s) heretofore have been expunged.");
-            ui.makeResponse(getDisplay());
+
+            ui.makeResponse(getDisplayEntriesReversed());
         } catch (ParserException e) {
             throw new EarlException(
                     "The indices' format is fraught with invalidity."

diff --git a/src/main/java/earl/logic/MarkHandler.java b/src/main/java/earl/logic/MarkHandler.java
@@ -26,6 +26,7 @@ public void handle(TaskList tasks, Ui ui) throws EarlException {
                         + "valid indices in range.");
                 return;
             }
+
             for (int idx : indices) {
                 boolean success = tasks.get(idx).markAsDone();
                 String feedback = idx + 1 + "." + tasks.get(idx);
@@ -35,7 +36,8 @@ public void handle(TaskList tasks, Ui ui) throws EarlException {
                 addDisplayEntry(feedback);
             }
             addDisplayEntry("Item(s) duly accomplished.");
-            ui.makeResponse(getDisplay());
+
+            ui.makeResponse(getDisplayEntriesReversed());
         } catch (ParserException e) {
             throw new EarlException(
                     "The indices' format is fraught with invalidity."

diff --git a/src/main/java/earl/logic/MassOperableHandler.java b/src/main/java/earl/logic/MassOperableHandler.java
@@ -39,7 +39,8 @@ protected void addDisplayEntry(String entry) {
         modifiedItems.add(entry);
     }
 
-    protected String[] getDisplay() {
+    // Returns the added display entries in reversed order
+    protected String[] getDisplayEntriesReversed() {
         Collections.reverse(modifiedItems);
         String[] result = modifiedItems.toArray(String[]::new);
         modifiedItems.clear();

diff --git a/src/main/java/earl/logic/UnmarkHandler.java b/src/main/java/earl/logic/UnmarkHandler.java
@@ -24,6 +24,7 @@ public void handle(TaskList tasks, Ui ui) throws EarlException {
                         + "valid indices in range.");
                 return;
             }
+
             for (int idx : indices) {
                 boolean success = tasks.get(idx).markUndone();
                 String feedback = idx + 1 + "." + tasks.get(idx);
@@ -33,7 +34,8 @@ public void handle(TaskList tasks, Ui ui) throws EarlException {
                 addDisplayEntry(feedback);
             }
             addDisplayEntry("Item(s) persist as undone.");
-            ui.makeResponse(getDisplay());
+
+            ui.makeResponse(getDisplayEntriesReversed());
         } catch (ParserException e) {
             throw new EarlException(
                     "The indices' format is fraught with invalidity."

diff --git a/src/main/java/earl/util/TaskList.java b/src/main/java/earl/util/TaskList.java
@@ -40,8 +40,6 @@ public int getSize() {
     public Task get(int i) {
         return tasks.get(i);
     }
-
-    /** Returns the added task itself. */
     public void add(Task task) {
         tasks.add(task);
     }

diff --git a/src/main/java/earl/util/Ui.java b/src/main/java/earl/util/Ui.java
@@ -29,7 +29,7 @@ private void setPrevResponse(String... arr) {
         response = arr;
     }
 
-    /** Displays a horizontal divider for TUI mode. */
+    /** Displays a horizontal divider for CLI mode. */
     private static void printDivider() {
         System.out.println(PADDING + DIVIDER);
     }
@@ -84,8 +84,7 @@ public String appendNewline(String line) {
     /**
      * Returns the previous response made for GUI interactions.
      *
-     * @return  the previous response appearing as it would on a
-     *          text based UI
+     * @return  the previous response appearing as it would on a CLI
      */
     public String getResponse() {
         int n = response.length;