Add h5vcc.system user on exit strategy. #4915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b/385357645
yell0wd0g
reviewed
Feb 18, 2025
|
|
||
| Configuration::Configuration() { | ||
| configuration_api_ = static_cast<const CobaltExtensionConfigurationApi*>( | ||
| SbSystemGetExtension(kCobaltExtensionConfigurationName)); |
There was a problem hiding this comment.
Where does access to SbSystem...() functions take place? At a guess I'd say this should happen in the browser process, and perhaps in the UI thread (if it can block, possibly in the IO thread). If so then this class' methods should be protected with DCHECK_CURRENTLY_ON(content::BrowserThread::UI); (or ...::IO);.
I see this method is being called directly from a Blink Object, which lives in the main Renderer thread; it would trigger that assertion. We'll need a Mojo interface to access this guy in all likelihood.
@andrewsavage1 FYI
There was a problem hiding this comment.
Isn't it being called from h5vcc_system_impl.cc (i.e. going through mojo)?
yell0wd0g
requested changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/385357645
b/394646160