Merge pull request #66 from yujiosaka/fix_annotation

Fix annotation

cache/.eslintrc.js

@@ -0,0 +1,6 @@
+module.exports = {
+  "extends": "../.eslintrc.js",
+  "rules": {
+    "no-unused-vars": 0,
+  },
+};

cache/base.js

@@ -34,7 +34,7 @@ class BaseCache {
    * @param {!string} key
    * @return {!Promise}
    */
-  get() {
+  get(key) {
     throw new Error('Get is not overridden!');
   }
 
@@ -43,7 +43,7 @@ class BaseCache {
    * @param {!string} value
    * @return {!Promise}
    */
-  set() {
+  set(key, value) {
     throw new Error('Set is not overridden!');
   }
 
@@ -53,31 +53,31 @@ class BaseCache {
    * @param {!number=} priority
    * @return {!Promise}
    */
-  enqueue() {
+  enqueue(key, value, priority) {
     throw new Error('Enqueue is not overridden!');
   }
 
   /**
    * @param {!string} key
    * @return {!Promise}
    */
-  dequeue() {
+  dequeue(key) {
     throw new Error('Dequeue is not overridden!');
   }
 
   /**
    * @param {!string} key
    * @return {!Promise<!number>}
    */
-  size() {
+  size(key) {
     throw new Error('Size is not overridden!');
   }
 
   /**
    * @param {!string} key
    * @return {!Promise}
    */
-  remove() {
+  remove(key) {
     throw new Error('Remove is not overridden!');
   }
 }

cache/session.js

@@ -27,7 +27,9 @@ class SessionCache extends BaseCache {
    * @return {!Promise}
    * @override
    */
-  close() {}
+  close() {
+    return Promise.resolve();
+  }
 
   /**
    * @param {!string} key

lib/async-events.js

@@ -4,7 +4,7 @@ class AsyncEventEmitter extends EventEmitter {
   /**
    * @param {!string} event
    * @param {...*} args
-   * @param {!Promise}
+   * @return {!Promise}
    */
   emit(event, ...args) {
     const promises = [];

lib/crawler.js

@@ -21,7 +21,7 @@ const jQueryPath = require.resolve('jquery');
 
 class Crawler {
   /**
-   * @param {!Puppeteer.Page} page
+   * @param {!puppeteer.Page} page
    * @param {!Object} options
    */
   constructor(page, options) {
@@ -80,6 +80,7 @@ class Crawler {
     return this._page.evaluateOnNewDocument(() => {
       window.open = (url => {
         window.location.href = url;
+        return window;
       });
     });
   }
@@ -129,7 +130,7 @@ class Crawler {
   _handlePageEvents() {
     this._page.on('pageerror', msg => void debugConsole(msg));
     this._page.on('console', msg => void debugConsole(`${msg.type} ${msg.text} at ${this._options.url}`));
-    this._page.on('dialog', dialog => this._handleDialog(dialog, this._options));
+    this._page.on('dialog', dialog => this._handleDialog(dialog));
   }
 
   /**

lib/hccrawler.js

@@ -231,7 +231,7 @@ class HCCrawler extends EventEmitter {
   }
 
   /**
-   * @return {!bolean}
+   * @return {!boolean}
    */
   isPaused() {
     return this._queue.isPaused();
@@ -342,7 +342,7 @@ class HCCrawler extends EventEmitter {
   }
 
   /**
-   * @param {!string} robotsUrl
+   * @param {!string} url
    * @return {!Promise<?string>}
    * @private
    */
@@ -423,7 +423,7 @@ class HCCrawler extends EventEmitter {
 
   /**
    * @param {!Object} result
-   * @return {!Promise<?boolean>}
+   * @return {!Promise}
    * @private
    */
   _success(result) {
@@ -433,7 +433,7 @@ class HCCrawler extends EventEmitter {
 
   /**
    * @param {!Error} error
-   * @return {!Promise<?boolean>}
+   * @return {!Promise}
    * @private
    */
   _error(error) {

lib/helper.js

@@ -38,7 +38,7 @@ class Helper {
    */
   static hash(src) {
     const md5hash = crypto.createHash('md5');
-    md5hash.update(src, 'binary');
+    md5hash.update(src, 'utf8');
     return md5hash.digest('hex');
   }