[mlir][parser] Extend AsmParser with slash token and optional floats #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a token for a forward slash to the token definition list and the methods to `AsmParser::parseSlash()` and `AsmParser::parseOptionalSlash()`, similar to other tokens used as operators (e.g., star, plus, etc.). This allows implementations of attributes that contain arithmetic expressions to support an operator using a forward slash, e.g., a division.
andidr
force-pushed
the
andi/parser-extensions
branch
from
9b1128f to
b920cd6
Compare
andidr
changed the title
andidr
force-pushed
the
andi/parser-extensions
branch
from
cea12f2 to
ba0006e
Compare
andidr
changed the title
This adds a new method `parseOptionalFloat` to `AsmParser` that attempts to parse a floating point value. Unlike `parseFloat`, no errors are emitted and all tokens are put back if parsing fails.
The current detection logic will fail for containers with an overloaded `push_back` member. This causes issues with types like `std::vector` and `SmallVector<SomeNonTriviallyCopyableT>`, which have both `push_back(const T&)` and `push_back(T&&)`. Reviewed By: rriddle Differential Revision: https://reviews.llvm.org/D147101
…mParser Add the methods `AsmParser::pushLexerPos()` and `AsmParser::popLexerPos()` that allow parsing code to speculatively parse portions of the input and to back off in case of a failure.
andidr
force-pushed
the
andi/parser-extensions
branch
from
0c3e146 to
146ae26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit adds a token for a forward slash to the token definition list and the methods to
AsmParser::parseSlash()andAsmParser::parseOptionalSlash(), similar to other tokens used asoperators (e.g., star, plus, etc.). This allows implementations of attributes that contain arithmetic expressions to support an operator using a forward slash, e.g., a division.
The second commit adds a new method
parseOptionalFloattoAsmParserthat attempts to parse a floating point value. UnlikeparseFloat, no errors are emitted and all tokens are put back if parsing fails.