Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document bug #376

Merged
merged 4 commits into from
Feb 11, 2025
Merged

document bug #376

merged 4 commits into from
Feb 11, 2025

Conversation

NicoJDE
Copy link
Contributor

@NicoJDE NicoJDE commented Feb 6, 2025

No description provided.

@ralf401
Copy link
Contributor

ralf401 commented Feb 7, 2025

Hi @NicoJDE,

thanks a lot for your contribution. However, you should apply some tweaks to your text, suggestion:

.. hint::
   Customers can't set a priority for their own tickets.
   For more context, have a look at the `Github-Issue <https://github.com/zammad/zammad/issues/814>`_.

Please make sure to run a make gettext before you commit. This updates the translation catalog.

To test if a proper HTML is generated, use make html and open the created index.html.

@NicoJDE
Copy link
Contributor Author

NicoJDE commented Feb 10, 2025

@ralf401 thanks for the hint. Now it should work.

I have also repaired the Depecndecies

Copy link
Contributor

@ralf401 ralf401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! :-D

@ralf401
Copy link
Contributor

ralf401 commented Feb 11, 2025

Seems like the translation catalog is still out of date. Can you please update it once more with make gettext? Thank you!

@NicoJDE
Copy link
Contributor Author

NicoJDE commented Feb 11, 2025

No changes found

$ make gettext
sphinx-build -b gettext   . locale
Sphinx v8.1.3 in Verwendung
WARNING: Calling get_html_theme_path is deprecated. If you are calling it to define html_theme_path, you are safe to remove that code.
Lade Übersetzungen [en]…erledigt
Converting `source_suffix = '.rst'` to `source_suffix = {'.rst': 'restructuredtext'}`.
loading pickled environment... The configuration has changed (1 option: 'html_static_path')
erledigt
building [gettext]: targets for 0 template files
reading templates... 
building [gettext]: targets for 50 source files that are out of date
updating environment: 0 added, 0 changed, 0 removed
reading sources... 
looking for now-outdated files... none found
preparing documents... erledigt
copying assets... 
copying assets: erledigt
writing output... [100%] snippets/ui-protip-message-editor-features
writing message catalogs... [100%] user-docs
build succeeded, 1 warning.

The message catalogs are in locale.

Created or updated POT file in locale.

@ralf401
Copy link
Contributor

ralf401 commented Feb 11, 2025

No changes found

Hmm strange. I pulled your branch and there were changes in the translation catalog. Let's see if it works now...

@ralf401 ralf401 merged commit bca7af0 into zammad:pre-release Feb 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants