Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Log4j 2 from runtime classpath of add-ons #6061

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

thc202
Copy link
Member

@thc202 thc202 commented Jan 3, 2025

Prevent the inclusion of the Log4j 2 API and implementation as those are already included by core and would cause conflicts making add-ons to not use the same classes/configs as core.
Remove now redundant local exclusions.


This was reported for exim and, after double checking the dependencies of all add-ons, that's the only one affected.

@psiinon
Copy link
Member

psiinon commented Jan 3, 2025

Logo
Checkmarx One – Scan Summary & Detailsacd164b6-7dc7-467c-8e4e-1d030cda301a

No New Or Fixed Issues Found

Prevent the inclusion of the Log4j 2 API and implementation as those
are already included by core and would cause conflicts making add-ons
to not use the same classes/configs as core.
Remove now redundant local exclusions.

Signed-off-by: thc202 <thc202@gmail.com>
@thc202 thc202 force-pushed the exclude-log4j2-runtime branch from 649d3fe to e17a51f Compare January 4, 2025 10:42
@thc202 thc202 changed the title [WIP] Exclude Log4j 2 from runtime classpath of add-ons Exclude Log4j 2 from runtime classpath of add-ons Jan 4, 2025
Copy link
Member

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@psiinon psiinon merged commit 6adcc67 into zaproxy:main Jan 6, 2025
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
@thc202 thc202 deleted the exclude-log4j2-runtime branch January 6, 2025 09:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants