authhelper: auth detection rewrite #6276
Open
+1,265
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh, test pain 😦 |
kingthorin
reviewed
Mar 13, 2025
addOns/authhelper/src/main/java/org/zaproxy/addon/authhelper/AuthUtils.java
Show resolved
Hide resolved
| for (SessionToken token : tokens) { | ||
| if (token.getSource().equals(kvPair.first) | ||
| && token.getKey().equals(kvPair.second)) { | ||
| count += 1; |
There was a problem hiding this comment.
Why not count++ ? Not that this is wrong, it just seems strange for our code base.
addOns/authhelper/src/main/java/org/zaproxy/addon/authhelper/internal/ClientSideHandler.java
Outdated
Show resolved
Hide resolved
psiinon
force-pushed
the
authhelper/auto-rewrite
branch
from
d8bf2b2 to
81e9c4d
Compare
|
Great job, no security vulnerabilities found in this Pull Request |
psiinon
force-pushed
the
authhelper/auto-rewrite
branch
6 times, most recently
from
6e69a14 to
f6e9b83
Compare
Signed-off-by: Simon Bennetts <psiinon@gmail.com>
psiinon
force-pushed
the
authhelper/auto-rewrite
branch
from
f6e9b83 to
b09623d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Related Issues
Checklist
./gradlew spotlessApplyfor code formattingFor more details, please refer to the developer rules and guidelines.